Skip to content

Add files via upload#401

Open
sbhyde-superstar wants to merge 1 commit into
notepad-plus-plus:masterfrom
sbhyde-superstar:master
Open

Add files via upload#401
sbhyde-superstar wants to merge 1 commit into
notepad-plus-plus:masterfrom
sbhyde-superstar:master

Conversation

@sbhyde-superstar

Copy link
Copy Markdown

This is the native language of ThinkOrSwim. A trading platform owned and provided by Charles Schwab. It is the most popular and widely distributed trading platform in the US.

This is the native language of ThinkOrSwim. A trading platform owned and provided by Charles Schwab. It is the most popular and widely distributed trading platform in the US.
@pryrt pryrt added the needs improvement will be rejected if requested improvement isn't made label Jul 16, 2026
@pryrt

pryrt commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Initial Problems:

  • The udl-list.json needs to be updated.
  • Nothing in the submission was placed in the right directories/location.
    • Don't create a new XML directory. That's not the right structure for this repo.
    • The automated checkers didn't find anything because it cannot see anything in your submission, because nothing is in the right place.
  • The overrideMap should not be submitted, as it's not part of the repo.

Please follow the structure and naming conventions and other rules for submissions, as explained in CONTRIBUTING.md

@sbhyde-superstar

sbhyde-superstar commented Jul 16, 2026 via email

Copy link
Copy Markdown
Author

@pryrt

pryrt commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I did update the udl-list.json. Did it not make it?

I do not see any modifications to the udl-list.json file in the change list. If you click on the "Files Changed" tab, you will see that udl-list.json is not in the list of changed files. Did you include your updates in your push to your branch?

I saw nothing about a directory structure.

CONTRIBUTING.md Point 9 literally says, "each file must go in the right directory in the repository", and the items below list which directory each goes into.

  • You need to put the UDL file as UDLs\thinkScript_bySBHyde.xml, not as XML\thinkScript.xml
    • see point 2 in the CONTRIBUTING.md file, which says, "The XML file must be given a unique name, because of the file structure. The name must include the name of the language, but also something else to make it unique.".
    • Thus, my suggested rename includes not only the correct directory, but also making the filename meet the requirement of point 2.
    • Point 9 confirms the correct directory.
  • You need to put the auto-completion file as autoCompletion\thinkScript.xml, not as XML\autoCompletion\thinkScript.xml
    • see point 7 in CONTRIBUTING.md for the correct location, and naming requirements
    • Point 9 confirms the correct directory.
  • You need to put the FunctionList definition as functionList\thinkScript.xml, not as XML\functionList\thinkScript.xml
    • see point 8 in CONTRIBUTING.md for the correct location, and naming requirements
    • Point 9 confirms the correct directory
  • You need to put the sample file as UDL-samples\thinkScript_bySBHyde.ts, not as .\Sample.ts
    • See point 6 for the rules about including a sample file if you've got a functionList, and for the directory it needs to go in
    • Point 9 confirms the correct directory

There is a lot to read

It's about a page of text. I am sorry if that's a lot of text to you, but the document was created so that anyone could read it, and follow its instructions, to get everything into the repo in a consistent manner. Without those rules, it makes for unusable chaos, which would then be useful to no one when they try to use one of these UDLs and the associated files.

@sbhyde-superstar

sbhyde-superstar commented Jul 16, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs improvement will be rejected if requested improvement isn't made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants