Add files via upload#401
Conversation
This is the native language of ThinkOrSwim. A trading platform owned and provided by Charles Schwab. It is the most popular and widely distributed trading platform in the US.
|
Initial Problems:
Please follow the structure and naming conventions and other rules for submissions, as explained in CONTRIBUTING.md |
|
PeterCJ -- thought I did follow the directions.
I am not familiar with GitHub or exactly what you want.There is a lot to
read and I am sure it is totally clear to you, but not to someone who is
unfamiliar with all this.
Exactly what directory structure would you like? I saw nothing about a
directory structure, and since all the files have the same name, I had to
do something
I did update the udl-list.json. Did it not make it?
Steven Hyde
…On Thu, Jul 16, 2026 at 2:48 PM PeterCJ ***@***.***> wrote:
*pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#401)
<#401 (comment)>
Initial Problems:
- The udl-list.json needs to be updated.
- Nothing in the submission was placed in the right
directories/location.
- Don't create a new XML directory. That's not the right structure
for this repo.
- The automated checkers didn't find anything because it cannot see
anything in your submission, because nothing is in the right place.
- The overrideMap should not be submitted, as it's not part of the
repo.
Please follow the structure and naming conventions and other rules for
submissions, as explained in CONTRIBUTING.md
<http:///notepad-plus-plus/userDefinedLanguages/blob/master/CONTRIBUTING.md>
—
Reply to this email directly, view it on GitHub
<#401?email_source=notifications&email_token=AMKVPF2EI7NDK6EV5I7HFRL5FEWPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGU4TKMJUGQ3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4995951446>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPFZIIUPGBZIE67IWPDT5FEWPVAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOBZHAYDONBWGEZ2C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPFZMNVDL6RAKMC566BL5FEWPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGU4TKMJUGQ3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AMKVPF7TJXGII6BYLPYIB6L5FEWPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGU4TKMJUGQ3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I do not see any modifications to the udl-list.json file in the change list. If you click on the "Files Changed" tab, you will see that udl-list.json is not in the list of changed files. Did you include your updates in your push to your branch?
CONTRIBUTING.md Point 9 literally says, "each file must go in the right directory in the repository", and the items below list which directory each goes into.
It's about a page of text. I am sorry if that's a lot of text to you, but the document was created so that anyone could read it, and follow its instructions, to get everything into the repo in a consistent manner. Without those rules, it makes for unusable chaos, which would then be useful to no one when they try to use one of these UDLs and the associated files. |
|
Thanks .. will attempt later this evening
Steven Hyde
…On Thu, Jul 16, 2026 at 3:31 PM PeterCJ ***@***.***> wrote:
*pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#401)
<#401 (comment)>
I did update the udl-list.json. Did it not make it?
I do not see any modifications to the udl-list.json file in the change
list. If you click on the "Files Changed" tab
<http:///notepad-plus-plus/userDefinedLanguages/pull/401/changes>, you
will see that udl-list.json is not in the list of changed files. Did you
include your updates in your push to your branch?
I saw nothing about a directory structure.
CONTRIBUTING.md
<http:///notepad-plus-plus/userDefinedLanguages/blob/master/CONTRIBUTING.md>
Point 9 literally says, "each file must go in the right directory in the
repository", and the items below list which directory each goes into.
- You need to put the UDL file as UDLs\thinkScript_bySBHyde.xml, not
as XML\thinkScript.xml
- see point 2 in the CONTRIBUTING.md file, which says, "The XML
file must be given a unique name, because of the file structure. The name
must include the name of the language, but also something else to make it
unique.".
- Thus, my suggested rename includes not only the correct
directory, but also making the filename meet the requirement of point 2.
- Point 9 confirms the correct directory.
- You need to put the auto-completion file as
autoCompletion\thinkScript.xml, not as
XML\autoCompletion\thinkScript.xml
- see point 7 in CONTRIBUTING.md for the correct location, and
naming requirements
- Point 9 confirms the correct directory.
- You need to put the FunctionList definition as
functionList\thinkScript.xml, not as XML\functionList\thinkScript.xml
- see point 8 in CONTRIBUTING.md for the correct location, and
naming requirements
- Point 9 confirms the correct directory
- You need to put the sample file as
UDL-samples\thinkScript_bySBHyde.ts, not as .\Sample.ts
- See point 6 for the rules about including a sample file if you've
got a functionList, and for the directory it needs to go in
- Point 9 confirms the correct directory
There is a lot to read
It's about a page of text. I am sorry if that's a lot of text to you, but
the document was created so that anyone could read it, and follow its
instructions, to get everything into the repo in a consistent manner.
Without those rules, it makes for unusable chaos, which would then be
useful to no one when they try to *use* one of these UDLs and the
associated files.
—
Reply to this email directly, view it on GitHub
<#401?email_source=notifications&email_token=AMKVPF7CMBQDQEKB7FJUDJD5FE3TBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGYZTANRWGM22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4996306635>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPFYJYCIH2DMTVOZF3Z35FE3TBAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOBZHAYDONBWGEZ2C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPF6XGUL5YFJJNVSPVOD5FE3TBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGYZTANRWGM22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AMKVPFYB4GIOHKUKQIFIMAT5FE3TBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGYZTANRWGM22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This is the native language of ThinkOrSwim. A trading platform owned and provided by Charles Schwab. It is the most popular and widely distributed trading platform in the US.