Conversation
stop() sets the stop flag and calls CFRunLoopStop, then joins the runloop thread. If that happens after the thread has checked the flag but before CFRunLoopRun starts, the stop is discarded and the join blocks forever. Run the loop with a bounded timeout and re-check the flag after each return. The workspace also resolves notify-types from crates.io so this fork shares event types with published consumers. (cherry picked from commit 9a8265f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some situations, such as rapid watch/unwatch cycles,
FsEventWatchercan intermittently hang due to a race condition involvingCFRunLoop. This PR adds an extra layer of safety:CFRunLoopruns in a loop with a 0.5-second timeout per iteration. Thestop_flag_threadflag is checked on every iteration, thus eliminating this hang.The race condition can occur when
CFRunLoopStopis called in the gap between checkingstop_flag_threadandCFRunLoopRunactually starting the loop internally.Related Issues
Related to #118 and #208. This addresses the stop-before-run race described in #118.