Convert /api/galaxy endpoints to Fetch requests against Galaxy's web API - #81
Open
johnwduggan wants to merge 8 commits into
Open
johnwduggan wants to merge 8 commits into
johnwduggan wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Original Issue
#72
Summary of Changes
Polling Galaxy via bioblend has proven inefficient and error-prone. I have rewritten the front-end to poll Galaxy via web transactions since we have already converted it to run it on a subdomain of Galaxy. This reduces the latency of the monitoring loop from 1-5 seconds down to a few dozen milliseconds.
I have additionally added support for listening to server-side events in most cases to detect when job status changes in Galaxy so we don't have to explicitly poll, though some things (such as file ingestion for auto-launch) don't fire SSE events so I have retained a backup polling interval.
The
is_admincheck still uses the dashboard's server-side since we don't want users to be able to bypass it. We can remove this in the future once we remove the database holding banner messages.I've tested each non-TODO row in the run sheet in the tests on ndip-dev which currently has these changes deployed. I encourage you to do the same as this is a very fundamental change to the way the dashboard works and regressions will be easy to introduce here.
Checklist
Documentation Updates
Additional Notes
Closes #72
Closes #75 since we don't need bioblend any more (apart from
is_adminwhich needs to be run server-side and will be removed in a future PR).