Repository navigation
fix(sharedproxy,plugin,templates): lock across detach+down, leave retry, source-fallback refusal, tables.yaml only, err-to-zero (D-0929, D-0931, D-0938, D-1415, D-0917, D-0061) - #1005
Merged
Conversation
… advertises platform signatures (D-1415)
… retry a failed leave reload; reattach on restart nginx (D-0929, D-0931)
getSchemaVersion returned (0, nil) when psql failed, so a broken database looked fresh and schema provisioning re-ran. health swallowed the dial error the start loop already stores. reclaimRunnerWork treated an unreadable _work as a healthy no-op. isCAInstalledWindows drops a dead certutil call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the cli side of D-0929, D-0931, D-0938, D-1415, D-0917, D-0061.
Per row
D-0938 Reworded the two operator-private path mentions (
internal/doctor/dogfood_checks.goFixCmd,scripts/ops/credential-rotation-check.shissue body). NewTestNoOperatorPrivatePathAdvicefails on origin/main, passes here. The P7-CI-45 grep exemption lives outside this repo (hq); it can be dropped once this merges.D-1415
verifyReleaseSignaturenow refuses a source artifact with E121 when the entry is a command plugin that advertisesplatform_signaturesfor this platform (pinned tiers; the dev bypass does not open it, since the signature entry is present). Seam tests added: platform asset 404 with a source tarball that has no binary, and with a binary; plus a control that an entry with noplatform_signaturesstill installs from source.TestInstallSourceFallbackRefusedE121fails on origin/main.D-0917 Dropped
multi-app/hasura/metadata.json.tables.yamlis the single source;TestMultiAppMetadataInSyncnow asserts the JSON is gone and the three tables are in the YAML, and the permission tests, the doctor isolation template test and the two e2e scripts readtables.yaml. README and wiki updated. Note: the ADOPT ticket AC text in hq still listshasura/metadata.jsonin the dry-run output. Also noteHasuraApplyMetadatasendsreplace_metadatafor the YAML directory layout too, sonself db hasura metadata applyon multi-app is still unsafe; the README warning stays and that command is a separate fix.D-0929 The compose pre-down hook now returns a release func.
sharedproxy.DetachHoldingtakes the owner lock, detaches and returns with the lock held;ComposeDownreleases it afterdocker compose down. An ownernself startcannot reattach in between (test: attach times out while held, works after release).D-0931 (a)
Leaverecordsnginx/shared/.reload-pendingonce the registration is gone and clears it after a successful reload (or when the owner is not running). A retry with no registration pays the reload; the owner'snself startand a repeatednself uninstallalso flush it. This is a marker rather than a live-config diff. (b) A restarting owner that an attach stopped is started again on any failed-attach exit (an owner the call did not stop is left as found). (c)nself restart nginxruns the reattach. Tests for each; the retry and start-back tests fail on origin/main.D-0061 Verified not landed:
getSchemaVersion,healthandreclaimRunnerWorkstill swallowed errors on main. The side session's fix was sitting unreviewed onorigin/fix/D-0061-err-to-zero(never PR'd). Cherry-picked it unchanged (3 behaviour fixes with tests, plus the dead certutil call inssl/trust.go). The other ~20 sites in that sweep were judged correct (guarded byos.IsNotExist), so I did not re-derive them.Checks run
go build ./...ok;go vet ./...clean;gofmt -lcleango test ./...: 11030 passed in 144 packages, 0 failedgolangci-lintis not installed on this worker, so not run.