Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The D-0609 rollup still contained local edge cases that could select legacy rollback from an empty state record, lose image rollback information, misclassify init services, or skip valid configuration. This change addresses those cases with regression coverage.
This PR remains draft because full deploy-suite verification did not complete locally. The targeted regressions and all other local checks below passed; the termination of the long suite remains unattributed.
Changes are split by concern: lock token invalidation and terminal detection; deploy-state and image-inspection validation; effective Compose init labels; nginx placeholder handling; Hasura metadata fidelity and directory identity; and CI dependency/vendor scanning. Behavior is documented in
.github/docs/maintenance-safety.md.PruneMarkedstill requires the generated marker (remote_sync.go:204), whileplugins_overlay.goandartifacts.gostage raw, unmarked plugin fragments. The row is explicitly assigned to P7-DEPL-24 in the planning debt-triage table and P7-DEPL-15/remote-apply work in its address-when field. No changes under the requested P7 exclusion.hq/plan/p7/epics/DEPL/tickets.yaml(docs/tasks). The requested P7 scope exclusion prevents this row's implementation. Spaced-home pin-file quoting is already fixed by59cd5857(#807).nself-...alias remains inssh_hostkeys.go; the row explicitly relates to P7-DEPL-29 and assigns alias cleanup to P7-SHIP/host-key ticket work.59cd5857(#807), and the fronted TLS gate byb740f87f(#901) /5a4eded5(#959); those paths were left unchanged. No outstanding P7 ticket specifically owns the remaining fixes.related: [P7-PLUG-60]places it outside this task's permitted scope.related: [P7-ADOPT-16]places the importer/fixture work outside this task's permitted scope.Validation against fresh
origin/mainat4628857c(Go 1.27.2, CGO disabled, vendor mode; temporary outputs in task scratch):go test -mod=vendor -count=1for wholeinternal/database(38.777s),internal/oplock(1.303s),internal/reconcile(60.371s), andinternal/build(119.961s); final targeted deploy-state and image-inspection regressions.go vet -mod=vendorandgo build -mod=vendorfor all five touched packages.make build BINARY="$TMPDIR/nself",make fmt-check, andgit diff --check.bash scripts/ci/affected-pkgs_test.sh(14 cases and positive control),bash scripts/ci/vendor-sync-check_test.sh, and shell syntax checks. The affected-package fixture itself passesgo test ./....TestDeployRollbackRestoresFront. That test passes against clean origin/main source in 105.173s.CGO_ENABLED=0 go test -mod=vendor ./internal/deploy -count=1 -timeout=20monac66b53bthen ended with exit 137 before its timeout, without diagnostic output. The cause is unknown; no claim is made that the aggregate termination is a baseline defect. No further heavy retries were attempted.GOTOOLCHAIN=go1.26.10 golangci-lint run --modules-download-mode=vendor ./internal/oplock ./internal/deploy ./internal/reconcile ./internal/build ./internal/database(zero issues, using the already-cached toolchain). The installed linter cannot decode Go 1.27.2 standard-library export data; that error also reproduces against clean origin/main.07785645:go test -mod=vendor ./internal/deploy -run 'TestSaveImageTags' -count=1, deploy vet/build, pinned-toolchain lint, formatting, and whitespace checks. This final classifier follow-up handles Docker's normalized missing-image names while refusing empty or multiline diagnostics.No hq changes, production connections, deployments, version changes, tags, or releases.
GitHub CI remains queued. Task scratch files have been removed.