Skip to content

fix(docker,importer): scope init cleanup to project, Appwrite paging limits (D-0687, D-0784) - #1011

Merged
acamarata merged 2 commits into
mainfrom
dw10-cli-8
Oct 28, 2026
Merged

acamarata merged 2 commits into
mainfrom
dw10-cli-8

Conversation

@acamarata

Copy link
Copy Markdown
Collaborator

D-0687

initContainerListArgs now takes the project name and adds --filter label=com.docker.compose.project=<project>, so nself start only removes its own project's finished init containers. RunPostStartCleanup passes the name through. Tests: argument-list test plus a fake-docker seam test that models two projects and asserts three scoped queries and only project-a removals (fails without the filter).

D-0784

  • Page size starts at 100 and halves on a >64 MiB response, down to 1 item; a single oversize item still fails. Retry is only for the byte-cap overflow.
  • --plan source users come from a 1-item count query; only when the total reaches the 5000 cap does it walk the list.
  • Downloads are hashed (MD5, compatibility only) and compared with the Appwrite signature when the server returns one, in addition to sizeOriginal.
  • Fixture seeds 250 books (e2e assertions updated) so real-server cursor paging passes one page. The e2e needs Docker/Linux CI and was not run here.
  • Wiki page Come-Home-Appwrite.md updated.

D-0781: not included (BLOCKED)

Discovery via an all-descendants runQuery with a pinned readTime cannot be validated here (no live Firestore or emulator), and a pinned readTime is only retained for about an hour without PITR, so hours-long exports of large databases would fail. Left for a change that can run against the emulator and live Firestore.

D-0579

Not included: already fixed in the open PR #999 (commit 4267540).

Verification

  • go build ./...: ok
  • go vet ./internal/docker ./internal/importer/...: ok
  • gofmt -l: clean
  • go test ./internal/docker ./internal/importer/...: all ok
  • Reverting the project filter makes the D-0687 tests fail.

@acamarata
acamarata merged commit 44a9631 into main Oct 28, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant