Repository navigation
fix(docker,importer): scope init cleanup to project, Appwrite paging limits (D-0687, D-0784) - #1011
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-0687
initContainerListArgsnow takes the project name and adds--filter label=com.docker.compose.project=<project>, sonself startonly removes its own project's finished init containers.RunPostStartCleanuppasses the name through. Tests: argument-list test plus a fake-dockerseam test that models two projects and asserts three scoped queries and only project-a removals (fails without the filter).D-0784
--plansource users come from a 1-item count query; only when the total reaches the 5000 cap does it walk the list.signaturewhen the server returns one, in addition tosizeOriginal.Come-Home-Appwrite.mdupdated.D-0781: not included (BLOCKED)
Discovery via an all-descendants
runQuerywith a pinnedreadTimecannot be validated here (no live Firestore or emulator), and a pinnedreadTimeis only retained for about an hour without PITR, so hours-long exports of large databases would fail. Left for a change that can run against the emulator and live Firestore.D-0579
Not included: already fixed in the open PR #999 (commit 4267540).
Verification
go build ./...: okgo vet ./internal/docker ./internal/importer/...: okgofmt -l: cleango test ./internal/docker ./internal/importer/...: all ok