Repository navigation
fix(catalog): make the -check baseline test hermetic - #1020
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalog determinism test used release inputs inside the real checkout, so
-checkfailed when that checkout lackedmainandorigin/main.Copy the fixture tree into a temporary Git repository, commit its release baseline, and create a local
mainref before checking the generated output. Add explicit coverage that a repository without either baseline ref is refused. Production behavior is unchanged.Validation passed in both the normal checkout and a
git clone --depth 1of the feature branch with neithermainnororigin/main:go test -mod=vendor -count=1 ./tools/catalog/...go build -mod=vendor -o <scratch>/catalog ./tools/cataloggo vet -mod=vendor ./tools/catalog/...