Repository navigation
test(nginxtopo): cover the uncovered branches back to 100 percent, add the promote/verify coverage floor - #920
Merged
Merged
Conversation
Collaborator
Author
|
Rebased onto origin/main to resolve the conflict in internal/nginxtopo/served_test.go and .github/coverage-floors.txt. Main already added TestSharedOwnerRegistered and a higher verify floor (92), so both stay as on main. This PR now adds the 'empty project' ServedDirs case and TestSharedOwnerRegistered_Layouts (missing, registered, non-directory nginx path). go test ./internal/nginxtopo passes at 100%. |
acamarata
force-pushed
the
job/h01-cli-coverage
branch
from
October 29, 2026 16:23
33120ab to
d67235c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage workflow was red on main: internal/nginxtopo 87.0 percent against a 98 percent floor. Table-driven tests bring it to 100.0 percent; the floor is unchanged; promote/verify gets a generated floor of 91 (measured 93.98).