Repository navigation
fix: debt batch j03-cli-debt-d-0651 - #926
Merged
Merged
Conversation
acamarata
changed the title
Collaborator
Author
|
Review fixes pushed in c1d7198:
|
acamarata
force-pushed
the
job/j03-cli-debt-d-0551
branch
from
October 29, 2026 16:23
c1d7198 to
1e61c16
Compare
Collaborator
Author
|
Rebased onto origin/main and resolved the secretenv.go doc-comment conflict by keeping main's wording (which already reflects the E421 refusal introduced in this branch). All internal/plugin and internal/invoke tests pass with -mod=vendor; force-pushed to job/j03-cli-debt-d-0551. |
…s (D-0651) - Guard in execPluginBinary now checks invoke.SecretsRestored() instead of NSELF_INVOKED_BY alone; machine-invoked plugin calls without secrets run. - Add SecretsRestored/TestingSetSecretsRestored in internal/invoke to track whether RestoreSecretArgv replaced placeholders in this process. - Update E421 text and MCP docs to describe the secret-bundle gate at exec time while keeping plugin tools advertised on machine surfaces. - Add tests for machine-invoked plugin execution without secrets, with secrets, ProxyBinaryAt containment, and plugin advertisement.
… and gofmt the error codes
acamarata
force-pushed
the
job/j03-cli-debt-d-0551
branch
from
October 29, 2026 23:05
1e61c16 to
e9c979e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex-built debt batch; one commit per row. Fixes D-0651: narrow plugin machine-execution guard to restored secret bundles, keep plugin tools advertised, update docs and E421 text.