Repository navigation
fix(upgrade,release,e2e): journal run_id charset, denylist wrapper at tag time, pgvector switch on pg15/17 (D-0715, D-0727, D-0806) - #995
Conversation
|
Fixed review finding CHANGES-1: |
|
Review fixes in 78e178c: release-create.sh now follows the D-0727 row's first option. With no dist/ DENY-001/002 are skipped with a note (draft or not), the unconditional non-draft guard and the IS_DRAFT special case are gone, so --skip-denylist works at tag time again; with dist/ present both rules are still enforced. Header docs, code and the PR body now agree. Case 1a asserts the exact outcome (rc 0, both skip notes, 'denylist: PASS', gh release create invoked); against the previous script 2 of 4 checks fail, all 4 pass now. Also moved the errs import into its own group in journal_test.go. go test ./internal/upgrade/... and gofmt/vet are clean. |
|
Reworded Release-Process.md:61. It no longer says release-create.sh would always refuse at tag time. It now says the script skips DENY-001/002 with a note when dist/ is absent and enforces them when dist/ is present (39b56b8). The change is docs only, so I ran no tests. |
… step to E139 (D-0715)
…DENY-004 to main (D-0727)
DENY-001 and DENY-002 previously skipped when dist/ was absent, allowing a direct non-draft gh release create to publish before build/signing/SBOM checks succeeded. The rules now fail without dist/, and --draft releases are exempt so the orchestrator can open the release shell first. An explicit guard also blocks non-draft publishes without verified artifacts. Updated the no-dist test to expect the block and added a draft path test.
…p the override (D-0727)
…ut dist/ (D-0727)
|
Rebased onto origin/main; TestPackageSizeBudget now passes locally (internal/plugin is within ceiling after main moved). Force-pushed bf0eb09 to dw9-cli-16. |
D-0715 (fixed)
validateJournalnow applies theruntimeRunIDcharset (^[a-zA-Z0-9-]+$) to the journalrun_id, so a hand-edited journal cannot put spaces, shell metacharacters or separators into the printed archive guidance or the archive file name.DefaultFixnow includes the archive step (move.nself/state/update-stack.jsonto.nself/state/update-stack.<run_id>.json);error-codes.mdregenerated withtools/wikigen.TestJournalRejectsContradictoryResumecases andTestE139DefaultFixIncludesArchiveStep; they failed before the fix (checked).D-0727 (fixed)
release-create.shskips DENY-001/002 with a note when there is nodist/(they stay enforced post-build by release.yml), and DENY-004 reads the license-audit run onmainonly.scripts/release-create_test.sh(fakegh, throwaway repo): 3 of 4 checks failed on the old script, all pass now.D-0806 (fixed, nightly run not verified here)
scripts/e2e/pgvector-switch.shtakesPOSTGRES_VERSION(major, default 16, unchanged behaviour) and asserts the start image and the pgvector target are of that major..github/workflows/pgvector-switch-e2e.yml: nightly 03:45 UTC, matrix 15 and 17, also runs on PRs touching the script or the workflow.Not in this PR
Checks
go test -mod=vendor ./internal/upgrade/... ./internal/errs/ ./tools/wikigen/ ./cmd/nself/ ./internal/repoqa/: 483 passedgo veton touched packages,wikigen -check: cleanbash scripts/release-create_test.sh: 4 passed;actionlinton the new workflow: clean;bash -non the e2e script: ok