Repository navigation
Conversation
…and replay it (D-0701)
…eal ci plugin (D-1217)
…echecks the set in the script (D-0778, D-0824)
guardedScript exits 1 if any act failed, build contexts resolve against the first compose file, checkMounts needs a destination under /etc/nginx, the scratch clear refuses symlinked .nself ancestors, the shipped list .new file is removed before the write, and the front cert find only treats a missing dir as empty.
…to satisfy package-size ratchet
Collaborator
Author
|
Rebased onto origin/main and extracted front-check helpers (sameNames, hasBuildMarker, serverNameSet, frontPruneBody, frontConfMax) from internal/deploy into a new internal/frontcheck package to bring the deploy package under the 6667-line ceiling. TestPackageSizeBudget and TestGofmtClean now pass; full module tests green. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows D-0697, D-0701, D-1217, D-0778, D-0824 (cli part). D-1216 is not changed.
Per row
internal/deploy/pintest.Home(already used by the controlplane and cmd/commands tests) returnedt.TempDir(), which is 0775 under umask 002 and is itself the refused ancestor. It now chmods the dir 0700. New test sets umask 002 and fails before the fix. The named controlplane tests andTestE487HintEnrollThenDeploypass underumask 002(they failed before).CaptureSourceManifestnow readsdocker compose ps --allnext to the images listing (when images rows carry no service) and replays it, so the compare step no longer lists containers live. Test fails before. Reworded the gosec nolint indeploy_promote.go; added a Windows note to.github/wiki/cmd-deploy.md. The Windows local runner argv form is not done (docs note only).ci evidence verify --jsonoutputs (plugins 076f5063, ci 1.2.13) inverify/testdata, fed throughcheckEvidence. Not done: matching digests to service names. The manifestArtifact.Nameis an operator-declared artifact name, not defined as a compose service, and the manifest contract is experimental until P8, so that needs a contract decision. The release-class golden is a real plugin report for a document edited tokind: release(exit 11), since a passing release run needs a container executor.sameNamesis false when either set is empty; checkFrontForeign refuses E485 and frontPrunable keeps the file. Table + behaviour tests. An existing test (TestFrontPruneOnlyOwnShipped) pruned a file with an empty recorded set; it now records a real server_name.rc=1on any failed act); build context base dir = first compose file; checkMounts requires a destination at/under/etc/nginx; clearScratch refuses symlinked.nself/.nself/deploy-build;rm -fthe.newpath before the redirect; cert find treats only a missing dir as empty; prune script rechecks the server_name set (same set asserverNameSet) and prints KEPT on mismatch. Each has a test that failed before. Not done: server_name recheck at rollback (needs the set recorded in the deploy record, a state schema change); the.env.<env>snapshot in the interpolation manifest is a product decision.Commands
go build ./...,go vet ./internal/deploy/... ./internal/controlplane/... ./cmd/commands/cleango test ./internal/deploy/... ./internal/controlplane/...okgo test ./cmd/commands/okumask 002; go test ./internal/deploy/pintest ./internal/controlplaneok (and the cmd/commands named test)