Repository navigation
fix(forgejo): remove stale runner docs and checks (D-0945, D-0944, D-0950) - #536
Merged
Merged
Conversation
Contributor
Author
|
Fixed review finding CHANGES-1: made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Healthy Forgejo stacks no longer print a failed check for a runner the plugin no longer ships. The published environment table and command help now describe external runners on separate CI nodes.
Verified against fresh
origin/mainatc2eac4eb5661d1f17ac952e8c3ed447d0f9df162; each row still applies.AGENTS.mdis a dangling link to the absent.claude/CLAUDE.md, so the supplied task rules apply.FORGEJO_RUNNER_*settings with the current manifest/environment variables, including closed-by-default registration. Link the README isolation, trust and migration guidance. Replace the retired network example with the existing owned-network fixture.--runnerflag from the legacy command, update the manifest and both embedded/captured help copies, and normalize future captures to preserve the correction. Drop obsolete Forgejo parity fixtures and their stub/server setup, documenting the intentional divergence from frozen core. The existing V15 server-only check and the legacy gate's exit behavior remain. Rationale:free/forgejo/README.mdexpressly assigns arbitrary workflow execution and runner management to a separate CI node, so local runner existence cannot determine forge health. Tests prove a healthy server succeeds without Docker, an unavailable server still warns, and the removed flag is rejected.free/ci/cmd/v15.goand run-lifecycle code.CancelRunstill persists only attempt intents andpreparePlanstill precedes coordinator policy resolution. No cancellation, policy-order, run-alias or acceptance-fixture changes are included, following the task's instruction to stop for an existing PR touching these files.Validation (Go 1.27.3, darwin/arm64; Go commands from
free/ci, with an isolated scratchGOCACHE):bash free/forgejo/tests/wiki-env-docs.shfails on the stale table/description/network example;go test -mod=vendor ./internal/forgejowith the new regressions fails because a healthy server reports a missing runner and Docker is invoked.bash scripts/lint-compose-network-literals.shPASS (68 fragments, 12 fixtures).go build -mod=vendor ./...andgo vet -mod=vendor ./...PASS.go test -mod=vendor ./internal/forgejo ./internal/surfacePASS; the wholecmdpackage also passes in the module run.origin/maincaptures reproduces all three updated golden files byte for byte: PASS.bash -non the changed shell scripts,python3 scripts/ci/check-file-size.py, andgit diff --checkPASS.go test -mod=vendor -p 2 ./...completed: all packages pass except three unrelated tests. Each failure reproduces on a clean archive of the baseline commit using the same Go cache:cmd/agent:TestServeStdioExitsNonZeroWithE663OnAProdStackMarkerreturns code 0 and empty stderr.internal/legacy:TestSecretsEnvLiveKeyGateTrackedValueOnlycannot track.environments/prod/.envbecause the worker Git ignore rules ignore it.internal/nodes/provision:TestInstallRunnerInstance_InheritedXtraceDoesNotLeakreports that tracing was not on (out="").Baseline comparison commands:
go test -mod=vendor ./cmd/agent -run '^TestServeStdioExitsNonZeroWithE663OnAProdStackMarker$',go test -mod=vendor ./internal/legacy -run '^TestSecretsEnvLiveKeyGateTrackedValueOnly$', andgo test -mod=vendor ./internal/nodes/provision -run '^TestInstallRunnerInstance_InheritedXtraceDoesNotLeak$'. All reproduce their respective failures.The initial shared Go cache had missing build artifacts; validation was repeated with a private scratch cache. No versions, releases, production configuration, hq files or repository settings changed. No hook exclusions were needed.