Repository navigation
test(pentest-kit): never read the owner licence key in tests (P7-PLUG-39) - #544
Merged
Merged
Conversation
The owner-key test read NSELF_PLUGIN_LICENSE_KEY_OWNER from the environment, so a test run on the owner's machine pushed the real all-access key into the gate. Use the fixed fixture only. This makes git grep for the owner variable empty, as P7-PLUG-39 acceptance needs. Refs: P7-PLUG-39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
free/pentest-kit/cmd/pentest_test.goreadNSELF_PLUGIN_LICENSE_KEY_OWNERfrom the environment and fed it to the gate under test. A test run on the owner's machine would push the real all-access key through test code (X-18). The test now uses the fixed fixture only.Why here
P7-PLUG-39 acceptance:
git grep -n NSELF_PLUGIN_LICENSE_KEY_OWNERin plugins returns nothing. The licensed preflight itself (scripts/preflight/licensed.sh,free/ci/internal/preflight/licensed*.go, wiki section) is already carried by #543 (land/p7f-plugins); this was the one remaining hit. It sits outside PLUG-39's listed write scope; it is the only way to meet that acceptance line.Verify
cd free/pentest-kit && go test -count=1 ./cmd/passesgit grep -n NSELF_PLUGIN_LICENSE_KEY_OWNERreturns nothingRefs: P7-PLUG-39