Repository navigation
test(ci): queue age feeds the auto tier wait, plan shows tier and wait (P7-AUTO-05) - #546
Merged
Merged
Conversation
…t (P7-AUTO-05) TestDispatchFillsQueuedMs: place derives QueuedMs from EnqueuedAt at the tick clock; a job never enqueued or a clock that went back reads as no wait. TestPlanShowsTierAndWait: under auto the held job's cell carries tier.waiting with the wait left, the chosen line shows tier and bias, and other presets print no tier text.
Contributor
Author
|
Folded into #543 (land/p7f-plugins) to land in one CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two tests P7-AUTO-05's verify lines name but #543 does not carry. Stacked on #543 (base
land/p7f-plugins). Test-only.internal/dispatch/queued_ms_test.goTestDispatchFillsQueuedMs:placederivesQueuedMsfromEnqueuedAtat the tick clock. It is read back through thetier.waitingdetail ("N ms left of step_sec"). A job never enqueued, or a clock that went back, reads as no wait. A job paststep_secruns on the lower tier.TestDispatchPlanFillsQueuedMsFromItsClock:Dispatcher.Planuses the configured clock.internal/planview/tier_wait_test.goTestPlanShowsTierAndWait: underauto, a held job's cell namestier.waiting, the held runner and the wait left. After the wait, the chosen line showstier <t> bias <n>.balancedprints no tier text.Verification (local, scoped)
CGO_ENABLED=0 go test -mod=vendor -count=1 -run 'TestDispatchFillsQueuedMs|TestDispatchPlanFillsQueuedMsFromItsClock|TestPlanShowsTierAndWait|TestTierRank' ./internal/dispatch/ ./internal/planview/gives ok, ok. gofmt is clean.Ticket: P7-AUTO-05