Repository navigation
fix(ci): go-test-ran ignores unrelated skips; TestRunsWait stable under load - #549
Merged
Merged
Conversation
A package run such as ./cmd/... always carries a few skips, so requiring zero skip events failed every verify line that used the script. It now requires a passing event for each named prefix, and still fails on any fail event, a non-JSON line, or a skipped test whose name starts with a named prefix.
The capped-wait subtest gave a 200 ms budget to a run that had to open the store and recover dead coordinators first, so on a loaded host the budget ended before the first read (state unknown, not running). It now uses a resolver that answers at once. The local-store timeout subtest accepts the same load tail. The stalled resolver counted its looks in a package variable that was never reset, so every repeat after the first started mid-count; the count now belongs to the resolver value.
A budget that ended before the store opened and the first read finished made the wait report state unknown with exit 10 for a run that exists. The first local read now gets up to firstReadGrace (half the invoke-deadline margin) even when the budget is shorter; later polls and remote lookups keep the budget. The wait subtests assert running again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for flakes that hit many P7 verify lines.
Proof: go test -count=20 -run TestRunsWait ./cmd/ on mm4 at load 11-14 passes twice; before, 5 of 20 failed.