Skip to content

fix(ci): generators list the bare hub command and every registered flag (P7-CI-62, P7-CI-48) - #552

Merged
acamarata merged 1 commit into
land/p7f-pluginsfrom
fix/ci-generator-gaps
Oct 30, 2026
Merged

acamarata merged 1 commit into
land/p7f-pluginsfrom
fix/ci-generator-gaps

Conversation

@acamarata

Copy link
Copy Markdown
Contributor

Generator fixes, output regenerated (not hand edited).

  • wiki plugin-page generator: machine_rows now emits the bare hub command, so CI.md gains nself_ci (remote, nonce). The other six hub plugins gain their bare row too.
  • refgen: flags registered through coordinator.RegisterListener (including the literal table in serve_user_listener.go) and flags defined in internal/nodes/lifecycle, coordinator/drain, config, doctor, discovery are now read. Reference.md gains --agent-addr, --api-addr, --api-socket, --api-lock, --enroll-addr, --agent-binary, --drain-deadline and others. Func/BoolFunc flag definitions are scanned.
  • Tests: bare-hub row tests (python), TestReferenceListsListenerAndPackageFlags, a table/literal listener test, an unresolvable-listener error test, and TestNoFlagDefinedOutsideScannedPackages, which fails when a new package defines flags refgen does not read.

Known gaps listed in the guard test (agent binary CLI, bench, gates/truth, jit and gitlab mint) need an owner command mapping. --max-queue, --prefer, --runner appear with no owning command (bare nself ci flags), as --no-status did before.

Stacked on #543. Not merged.

…ag (P7-CI-62, P7-CI-48)

The wiki plugin-page generator emitted rows for subcommands only, so
nself_ci had no machine-surface row. refgen read FlagSet calls in cmd
only, so listener flags (RegisterListener, one from a literal table)
and flags defined in internal packages were missing from Reference.md.
Both generators are fixed and the pages regenerated; tests fail on the
omission, and a guard test fails when a new package defines flags
refgen does not read.
@acamarata
acamarata merged commit 8decf6d into land/p7f-plugins Oct 30, 2026
15 of 19 checks passed
acamarata added a commit that referenced this pull request Oct 30, 2026
Drop the CI.md no-op test (the region no-op test already snapshots every
page, CI.md included) and two redundant lines; folding #552 pushed the
file to 308 lines.
@acamarata

Copy link
Copy Markdown
Contributor Author

Folded into #543 (land/p7f-plugins) to land in one CI run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant