Repository navigation
Conversation
Help was passed to the handler, so some subcommands ran (nself ci run --help) and nodes <sub> --coordinator <url> --help sent a request. Both dispatchers now intercept the flag before the handler and the remote client, print the captured core help or the flag defaults and child commands, and exit 0. A group word with no command of its own lists its children. A table test covers every registered key in both tables.
The checker passed its 10 minute block bound as a CPU ulimit, so an inner nself ci -- cmd job with its 30 minute default failed to raise the hard limit (ulimit: Operation not permitted). The bound now lives on the context only, so the inner job sets its own limit and a hung block still fails.
With the state directory inside the repo root the workspace lived inside the source and the copy recursed into itself. copyTree now skips the state dir and the workspace, and anything under them, when they lie inside the source.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs found while building P7-CI-48, stacked on land/p7f-plugins.
nself ci <sub> --help/-hreached the handler, so some subcommands ran (run) andnodes <sub> --coordinator <url> --helpsent a request. Both dispatchers now print the subcommand help and exit 0 before the handler and the remote client. Table test over every registered key in both tables.nself ci -- cmdjob (30m default) failed withulimit: Operation not permitted. The bound is now context-only.Tests: cmd (full), internal/exec (full), tools/*, architecture, internal/surface run with CGO_ENABLED=0 -mod=vendor on mm4. Do not merge: stacked.