Skip to content

fix(ci): clear the three red checks on main (file size, test import cycle, gVisor hang) - #561

Merged
acamarata merged 3 commits into
mainfrom
fix/main-red-hygiene-cycle-isolation
Oct 29, 2026
Merged

acamarata merged 3 commits into
mainfrom
fix/main-red-hygiene-cycle-isolation

Conversation

@acamarata

Copy link
Copy Markdown
Contributor

Fixes three breakages that are not from #543.

  1. hygiene file-size: free/ci/cmd/runs_wait.go was 304 lines. The run-source reads moved to runs_wait_poll.go, no behaviour change.
  2. detect-langs: the integration-tagged gates test imported internal/evidence, which reaches internal/run, which imports internal/gates (cycle in test). The lockfile-digest assertions now live in internal/evidence (TestInputsOfFixtureLockfiles).
  3. isolation (ubuntu): TestUntrustedAdhocSandboxed hangs in the nself-ci child until the 10 minute go test alarm. The test now bounds each command, sends SIGQUIT and fails with the goroutine dump, processes and containers. Root cause analysis continues from that output.

…s in internal/evidence

internal/evidence reaches internal/run, which imports internal/gates, so the integration-tagged gates test that called evidence.InputsOf failed to build (detect-langs). The same assertions now run in internal/evidence, which may import detect.
TestUntrustedAdhocSandboxed ran nself-ci with no time limit and hung until the 10-minute go test alarm, naming no cause. Each command now has a 5-minute budget, is sent SIGQUIT on expiry, and the failure carries the goroutine dump, process list and containers. The workflow passes -timeout 25m so the package alarm no longer pre-empts it.
@acamarata
acamarata merged commit 61bfd83 into main Oct 29, 2026
35 of 42 checks passed
@acamarata
acamarata deleted the fix/main-red-hygiene-cycle-isolation branch October 29, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant