Repository navigation
Fix inherited LuaObject member and metamethod replacements - #350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inherited [LuaMember] and [LuaMetamethod] declarations were emitted alongside explicitly annotated derived replacements. This made a derived constructor metamethod produce LUACS007, duplicated method wrapper fields, and sometimes silently selected a base property or method instead of a derived Lua alias.
Select the most derived annotated declaration for each Lua member name and metamethod. Enumerate overrides at every inheritance level so leaf types retain intermediate replacements. Member and metamethod bindings are selected independently when a method has both attributes. Definitions within the same declaring type remain available to existing duplicate diagnostics; this does not add overload support. Unannotated virtual overrides and the existing unannotated
newconstructor pattern retain their inherited exposure.Fixes #118.
Validation: