Repository navigation
Fix escaped closing brackets in Lua pattern classes - #357
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patterns containing an escaped closing bracket could terminate their character class too early. For example,
string.find("]", "[%]]")returnednilinstead of(1, 1), and the multi-element-array example in #356 failed to match.Check the character being consumed before advancing past its escape, matching Lua 5.2.4's
classendbehavior. Preserve literal brackets at the start of a class and reject unterminated classes such as[%].Add 24 regression cases covering all reported examples (including both returned positions), escaped and literal brackets, malformed classes, and shared behavior in
string.match,string.gmatch,string.gsub, and frontier patterns.Validation:
dotnet test --verbosity quietpassed all 512 runtime tests and 69 source-generator tests.Fixes #356.