Repository navigation
Fix zero-length pattern matches at the end of strings - #358
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern searches skipped the position after the last character unless the pattern itself was empty. This made
string.find("abc", "$")returnnilinstead of(4, 3)andstring.match("", "a*")returnnilinstead of an empty string.Include the end position in the search loops shared by
findandmatch, and ingmatchandgsub. Patterns requiring a character still fail there, while zero-length matches now follow Lua 5.2 behavior. Update the existinggmatch("abc", "a*")expectation to include the fourth match afterc.Add 44 regression cases covering empty inputs, end anchors, optional repetitions, position captures, start bounds, iterator termination, and substitution limits. All expected results were checked against native Lua 5.2.
Validation:
dotnet test --verbosity quiet: 556 runtime tests and 69 source-generator tests passed.dotnet csharpier check .: all 252 files passed using the repository's pinned formatter.git diff --check: passed.