Skip to content

TA-3804: add tentative-as-busy to calendar request#334

Merged
googsvg merged 1 commit into
mainfrom
TA-3804-add-tenative-as-busy-to-java-sdk
Jul 10, 2026
Merged

TA-3804: add tentative-as-busy to calendar request#334
googsvg merged 1 commit into
mainfrom
TA-3804-add-tenative-as-busy-to-java-sdk

Conversation

@googsvg

@googsvg googsvg commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds optional tentative_as_busy support to GetFreeBusyRequest in the Java SDK.

Changes

  • Added tentativeAsBusy: Boolean? = null to GetFreeBusyRequest

  • Preserved backward compatibility for Java callers with @jvmoverloads

  • Added unit tests for:

    • serializing tentative_as_busy when set
    • legacy 3-arg constructor compatibility
    • free-busy request body coverage
  • Updated CHANGELOG.md

Validation

  • ./gradlew test --tests com.nylas.resources.CalendarsTest
  • ./gradlew build

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@googsvg googsvg requested review from AaronDDM and samLRodrigues July 9, 2026 10:51
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.73%. Comparing base (3b233de) to head (a3929ca).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #334   +/-   ##
=========================================
  Coverage     83.73%   83.73%           
  Complexity      486      486           
=========================================
  Files            44       44           
  Lines          1359     1359           
  Branches        115      115           
=========================================
  Hits           1138     1138           
  Misses          149      149           
  Partials         72       72           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AaronDDM AaronDDM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning! 👀

Clean change. A few things I checked that look right:

  • @JvmOverloads keeps the legacy 3-arg constructor working, so existing Java callers won't break.
  • Nice that you assert the null case doesn't serialize tentative_as_busy — that keeps us from sending a null the API might misread.
  • CHANGELOG Unreleased entry and the doc comment are both in, and the tests cover set/unset plus the request-body path.

Optional, non-blocking: if tentative_as_busy isn't yet exposed in the other SDKs (node/python/ruby), worth a follow-up so free/busy stays consistent across them.

LGTM — approving.

@googsvg googsvg merged commit d0a9507 into main Jul 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants