Skip to content

Headers containing commas generate validation errors #114

Closed

Description

@jamesfcarter

When upgrading to v1.3.0 I started seeing errors like this:

Invalid format for parameter X-My-Header: parameter 'X-My-Header': expected single value, got 24 parts

X-My-Header was a JSON string containing commas.

This appears to be due to the headers now being run through splitStyledParameter which splits on comma and requires only one part. (#100)
I've worked around this by using a type that implements encoding.TextUnmarshaler to avoid it reaching that code but was this behaviour intended?

Thanks.

Activity

  1. mromaszewicz commented on Mar 19, 2026

    @mromaszewicz
    Member

    No, it wasn't intended. Thanks for reporting.

    I'll add test cases for this and fix it. It's difficult to infer intent from looking at data without context, so I've been fixing these bugs by passing down more context from higher levels.

  2. added theissue type on Mar 19, 2026
  3. added 2 commits that reference this issue on Mar 23, 2026
    4409647
    00e51fe
  4. mromaszewicz commented on Mar 25, 2026

    @mromaszewicz
    Member

    @jamesfcarter - I've pushed runtime v1.3.1 to address just this issue. Please let me know if it works for you, and reopen this issue if it doesn't.

  5. jamesfcarter commented on Mar 26, 2026

    @jamesfcarter
    Author

    This does work. Thanks for the speedy response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions