fix(detail): render approval-lock band from host signal on request-tracked backends (#2618) by os-zhuang · Pull Request #2619 · objectstack-ai/objectui

os-zhuang · 2026-07-16T15:55:35Z

Problem

The DetailView "Locked for approval" band keyed only off the record's own approval_status field:

const approvalStatus = data?.approval_status;
const isLocked = approvalStatus === 'pending' || approvalStatus === 'in_approval';

On backends that track the lock via an open approval request and never materialize an approval_status field on the record, the band never rendered — even though the lock was real (server rejects writes with RECORD_LOCKED, pencils hidden, save bar locked). Users saw editing silently disabled with no explanation banner.

RecordDetailView already computes the correct dual signal — approval_status ∈ {pending, in_approval} OR an open request from useRecordApprovals — and folds it into the inline-edit canEdit gate. The band just wasn't consuming it.

Fix (issue's option 1 — renderer-correct)

Thread the host's already-computed lock into the band via the record-level session, keeping DetailView DataSource-agnostic:

@object-ui/react — InlineEditContext gains a distinct locked / lockedReason signal (separate from !canEdit, which is true for many non-approval reasons). InlineEditProvider accepts and surfaces them.
@object-ui/app-shell — RecordDetailView passes locked={approvalLocked} (the same dual-source value already gating canEdit) plus the localized reason.
@object-ui/plugin-detail — the band reads inline?.locked first and falls back to the record's own field for bare/legacy usage; tooltip prefers inline?.lockedReason. Also backfills the approval-lock strings into DETAIL_DEFAULT_TRANSLATIONS so a provider-less DetailView shows the label instead of the raw i18n key.

This is not a lenient renderer fallback (AGENTS.md #0.1): the approvals API is an official lock signal that RecordDetailView already treats as authoritative, so the band is simply made consistent with the lock that has already engaged.

Tests

InlineEditContext.test.tsx — locked/lockedReason default to false/undefined and pass through from the provider.
DetailView.approvalBand.test.tsx (new) — band shows from the host locked signal with no approval_status field; uses lockedReason as tooltip; still shows from the record field for field-tracked backends; hidden when neither signal indicates a lock.

Full @object-ui/plugin-detail suite green (231 tests); @object-ui/react, @object-ui/plugin-detail, @object-ui/app-shell type-check clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AZLuEG1ZeMSMaTsoCgdks6

Generated by Claude Code

…acked backends (#2618) The DetailView "Locked for approval" band keyed only off the record's own `approval_status` field, so it never showed on backends that track the lock via an open approval request and never materialize that field — even though the lock was real (server rejects writes with RECORD_LOCKED and the inline-edit session correctly locks). Surface the host's already-computed lock as a distinct `locked`/`lockedReason` signal on the record-level InlineEditContext (the same dual-source `approvalLocked` that RecordDetailView already folds into `canEdit`), and have the band read it — keeping DetailView DataSource-agnostic. The record-field check stays as a fallback for bare/legacy usage. Also backfill the approval-lock strings into the detail translation defaults so a provider-less DetailView shows the label instead of the raw i18n key. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AZLuEG1ZeMSMaTsoCgdks6

vercel · 2026-07-16T15:55:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 16, 2026 3:55pm

github-actions · 2026-07-16T15:59:08Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.6 KB	350 KB
Entry file	`index-CFsW6hzy.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.17KB	2.95KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	448.19KB	97.29KB
core (index.js)	1.82KB	0.62KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	115.42KB	28.53KB
fields (index.js)	208.25KB	50.87KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.87KB	1.28KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.76KB	42.28KB
plugin-dashboard (index.js)	117.25KB	29.14KB
plugin-designer (index.js)	213.89KB	43.03KB
plugin-detail (index.js)	212.94KB	51.83KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.96KB	25.43KB
plugin-gantt (index.js)	149.18KB	37.17KB
plugin-grid (index.js)	172.00KB	45.43KB
plugin-kanban (index.js)	47.23KB	12.88KB
plugin-list (index.js)	97.69KB	23.10KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.63KB	9.92KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.72KB	20.86KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.67KB	0.75KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added package: react plugin tests labels Jul 16, 2026

os-zhuang marked this pull request as ready for review July 16, 2026 16:33

os-zhuang merged commit 59d4fa9 into main Jul 16, 2026
10 checks passed

os-zhuang deleted the claude/approval-band-visibility-ceuyod branch July 16, 2026 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(detail): render approval-lock band from host signal on request-tracked backends (#2618)#2619

fix(detail): render approval-lock band from host signal on request-tracked backends (#2618)#2619
os-zhuang merged 1 commit into
mainfrom
claude/approval-band-visibility-ceuyod

os-zhuang commented Jul 16, 2026

Uh oh!

vercel Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 16, 2026

Problem

Fix (issue's option 1 — renderer-correct)

Tests

Uh oh!

vercel Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants