Skip to content

fix(auth): 注册页去掉重复的「or」分隔线(与 #2629 登录页修复对齐)#2633

Merged
os-zhuang merged 6 commits into
mainfrom
fix/register-double-divider
Jul 17, 2026
Merged

fix(auth): 注册页去掉重复的「or」分隔线(与 #2629 登录页修复对齐)#2633
os-zhuang merged 6 commits into
mainfrom
fix/register-double-divider

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

staging 现场验证(2026-07-17,cloud.objectos.app/_console/register)抓到:#2629 修好了登录页的双分隔线,但注册页仍叠着「OR CONTINUE WITH EMAIL」(来自 SocialSignInButtons)+「OR」(来自 RegisterForm)两条。

删掉 RegisterForm 多余的 AuthDivider(与 LoginForm 同修),顺带清理已无消费者的 hasSocialProviders state 和 unused import。

测试

packages/auth 88 tests 全过,tsc --noEmit 干净。

🤖 Generated with Claude Code

os-zhuang and others added 6 commits July 17, 2026 09:02
…SO-only users on a password wall

Staging E2E (2026-07-17) on a freshly provisioned environment: the login
page's FIRST load rendered the plain password form — no "Continue with
ObjectStack", no ssoEnforced collapse — because the /auth/config fetch hung
or failed while the kernel cold-started, and both LoginForm and
SocialSignInButtons silently fell back to defaults. Platform-SSO JIT users
have no password, so this dead-ends the "open your environment" moment
(#2625). Clicking the SSO button inside the same cold-start window hung the
POST forever with the button stuck spinning (#2626).

- getConfig: single-flight + success cache (3 requests → 1) with retrying
  backoff (500ms/1.5s/3.5s, 8s per-attempt AbortController timeout) so a
  hung request converts into a retry; final failure clears the cache.
- LoginForm: hold a spinner until config resolves; on resolve, honour
  ssoEnforced on first paint. On final failure keep the old safe default
  (password form) — break-glass beats lock-out.
- signInWithProvider: 20s watchdog rejects a hung sign-in so the #2458
  button contract (pending + inline error) can recover it; legacy oauth2
  fallback failures no longer mask the social-route error.
- Drop LoginForm's duplicate "or" divider (SocialSignInButtons already
  renders one) — the stacked dividers read as a glitch.

Closes #2625. Closes #2626.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…t create dialog

Staging E2E (2026-07-17): the welcome hero's "Create your environment"
navigated to the environments list, where the user had to find and click a
SECOND create button — an extra hop on the very first thing a new user does
(#844).

- action:button: client-side `autoTrigger` flag — runs the action once on
  mount through the exact same execute path as a click (param dialog,
  confirm, entitlement gate all apply). Not persisted metadata; only client-
  composed schemas set it.
- EnvironmentListToolbar: consume `?runAction=create_environment` once
  entitlements resolve — setup_production / add_development mark the create
  action autoTrigger; upgrade-locked orgs open the upgrade prompt (the
  honest answer to "create" there). Param is stripped on consumption so
  refresh / back don't re-open the dialog. Router-free (location +
  replaceState) so non-Router hosts and tests keep working.
- CloudOnboardingNext: the create CTA navigates with the runAction param.
- i18n: the toolbar's state-aware label overrides were hard-coded English
  in a zh console — now {en,zh} via the same pick() pattern as the widget.

Closes #844.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…iately

Staging E2E (2026-07-17): clicking 开始搭建 (plan approve) showed no change
at the card for ~10s — the approval sends a chat message whose visible
effects (user bubble + streaming turn) land at the BOTTOM of the thread,
outside the viewport when the card is in view — so users assumed the click
was lost and clicked again (#2627).

- Track approved plan ids locally; the clicked card's buttons flip to a
  spinning "Building…" badge on click (both the structured plan card and
  the unstructured fallback gate). Built state still derives from the
  message stream (#432 semantics unchanged).
- An approval that never left the client (unsent error) rolls the badge
  back so the button returns; a newer typed/suggestion send supersedes the
  approve as "last send" so ITS failure can't roll back a delivered
  approval.
- New planBuildingLabel prop; AiChatPage passes 正在搭建… for zh
  conversations.

Partially addresses #2627 — the conversation-history-clears-after-build
race needs a live repro and stays open.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…had the same glitch as login)

Live staging verification (2026-07-17, cloud.objectos.app/_console/register)
caught that #2629 fixed the double divider on the LOGIN page but the SIGN-UP
page still stacked "OR CONTINUE WITH EMAIL" (from SocialSignInButtons) over a
second "OR" (from RegisterForm). Remove RegisterForm's redundant AuthDivider —
same fix as LoginForm — and clean up the now-unused hasSocialProviders state.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 17, 2026 9:29am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.6 KB 350 KB
Entry file index-wMOe8boX.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.17KB 2.95KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 449.19KB 97.54KB
core (index.js) 1.82KB 0.62KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 115.42KB 28.53KB
fields (index.js) 208.25KB 50.87KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 117.25KB 29.14KB
plugin-designer (index.js) 213.89KB 43.03KB
plugin-detail (index.js) 213.30KB 51.94KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 105.03KB 25.46KB
plugin-gantt (index.js) 149.18KB 37.17KB
plugin-grid (index.js) 173.23KB 45.75KB
plugin-kanban (index.js) 47.23KB 12.88KB
plugin-list (index.js) 97.69KB 23.10KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.63KB 9.92KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.72KB 20.86KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.67KB 0.75KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 022735f into main Jul 17, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the fix/register-double-divider branch July 17, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant