[FIX] hr: hide new contract button if no start date#5186
Open
LucasDaniOV wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-luoud, it needs to be retargeted before it can be merged. |
arpi-odoo
requested changes
Jun 23, 2026
arpi-odoo
left a comment
arpi-odoo
left a comment
There was a problem hiding this comment.
Code is good but the PR description should be the same as the commit message. You can always delete the automatic part that's added by github, it is only there for external people that want to contribute to odoo since the odoo repo is open source.
|
@LucasDaniOV I meant this part 😛 Also, the tag in the commit and PR title is not correct, this is a |
LucasDaniOV
changed the title
This hides the "New Contract" button if there is not an existing start date Task: 6326361
LucasDaniOV
force-pushed
the
master-hr-onboarding-new-contract-button-invisible-luoud
branch
from
f9ab1be to
8496fd4
Compare
Author
|
@arpi-odoo should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hides the "New Contract" button if there is not an existing start date
Task: 6326361