Repository navigation
feat(definition,template): add and remove charts, check-upgrade, upgrade, link-template (#157, #158) - #166
Merged
Conversation
…ade, link-template (#157, #158) - definition add-chart and remove-chart (devops or admin). remove-chart takes a chart name or ID and asks for confirmation unless --yes. - definition check-upgrade: the version change and a CHART/CHANGE table. Without an upgrade the server sends no reason; the command reads the template link of the definition. A chart with differences in chart_diffs (for example another chart version) shows as modified. -q prints yes or no. - definition upgrade: shows the check on stderr, warns that the template values replace the definition values, and asks unless --yes. - definition link-template --template <name|id> [--version] or --unlink (server v0.11.0 or later; a missing route gives an upgrade hint). - template add-chart and remove-chart change the working copy and write a note to publish with a new --version. - Flag names follow update-chart (--name, --repository-url, --chart-path, --chart-version, --file, --locked-file, --required, --deploy-order). - Refresh the vendored swagger.json (the contract test checks the new template-link path). Closes #157 Closes #158 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Definition commands (#157):
definition add-chart <definition> --name <chart> [--repository-url] [--chart-path] [--chart-version] [--source-repo-url] [--build-pipeline-id] [--deploy-order] [--file](devops or admin).definition remove-chart <definition> <chart>: chart name or ID; asks for confirmation unless--yes. A linked definition cannot lose a chart that the template requires (409).definition check-upgrade <definition>: the version change and aCHART/CHANGEtable.-qprintsyesorno.-o json|yamlincludeschart_diffswith the values of both sides.definition upgrade <definition> [--yes]: shows the check on stderr, warns that the template values replace the definition values, asks, then upgrades.definition link-template <definition> --template <name|id> [--version <v>]or--unlink(server v0.11.0 or later; a missing route gives an upgrade hint).Template commands (#158):
template add-chart <template> --name <chart> ... [--locked-file] [--required]andtemplate remove-chart <template> <chart> [--yes]. Both change the working copy and write a note to stderr: publish with a new--version.Notes
update-chartcommands (--repository-url,--chart-path,--chart-version,--file), not--repo,--path,--versionand--values-filefrom the issue text.--versionalready has another meaning inlink-templateandtemplate publish.{"upgrade_available": false}(no source template, unpublished template, or latest version). The command reads the definition to say which case applies.modifiedonly for other default values or another repository URL. The table also shows a chart asmodifiedwhen itschart_diffsentry hashas_differences(for example another chart version).swagger.jsonis refreshed from k8s-stack-managermain(refresh-swagger.sh). The path contract test checks the newtemplate-linkpath.Tests
go test ./...passes, alsogo test -shuffle=on ./cmd.staticcheck(latest) has no findings.cli/cmd/chart_changes_test.go(request bodies, usage errors, confirmation, no-upgrade reasons, 403 and 409, output modes) andcli/pkg/client/definition_charts_test.go.Closes #157
Closes #158
🤖 Generated with Claude Code