Repository navigation
test(contract): cover the notification list and count responses - #173
Merged
Merged
Conversation
Refresh testdata/swagger.json from k8s-stack-manager main (it now has #697, the capped notification counts) and add response cases for types.Notification, types.PaginatedNotifications and types.UnreadCountResponse (models.UnreadNotificationCount). A mistyped json tag such as "unread_count_caped" now fails the test instead of decoding to false. The existing cases pass against the refreshed schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172 and omattsson/k8s-stack-manager#697 (the capped notification counts, k8s-stack-manager #654).
Summary
cli/test/contract/testdata/swagger.jsonfrom k8s-stack-managermainwithrefresh-swagger.sh. The vendored copy was well behind; the existing cases pass against the new schema.types.Notificationagainstmodels.Notificationtypes.PaginatedNotificationsagainstmodels.PaginatedNotificationstypes.UnreadCountResponseagainstmodels.UnreadNotificationCountA mistyped json tag on these types (for example
unread_count_caped) now fails the contract test instead of silently decoding tofalse. I checked this by breaking the tag locally: both the list and the count case fail with "has no matching property in swagger schema".Note: response cases only check that each stackctl field exists in the schema. The backend's
triggerfield on a notification is not decoded by stackctl, and the test does not flag that.Tests
go vet ./...andgo test ./... -race -count=1pass.🤖 Generated with Claude Code