Skip to content

GeneralTaxonomy.tax_id_lookup should be no copy #19

Description

@bovee

Right now we need to copy each item from tax_ids into the HashMap as a key (to avoid making the struct self-referential) for its lookup, but if we didn't have to do this we'd save some memory.

Options:

  • Make tax_id_lookup self-referential somehow. There are a couple libraries to allow things like this, but the ones I looked at are questionably sound
  • Make tax_id_lookup a HashMap<hash, IntTaxId> and handle all the hashing and collision detection ourselves (reinvent a lot of the HashMap). This may be similar to the NoHashHasher in finch with an additional collision check.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions