Repository navigation
Open the setup screen on recommended models and name the CPU - #103
Merged
Merged
Conversation
The first screen led with hardware detail, so the answer to 'which model should I run?' sat below the fold behind a click. Once the hardware is read, the three recommendations now load on their own, and the System card folds its detail under one line naming the GPU, CPU, RAM and fit budget. Each recommendation request takes a sequence number and only the latest may write the panel, so a slow automatic request cannot replace what the user asked for. On Windows the CPU came from platform.processor(), which returns the raw 'AMD64 Family 25 Model 80' identifier. Read the registry name instead, and use sysctl on macOS. Bump the web asset version to ui35.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A new visitor lands on the Setup screen and sees hardware detail first: GPU rows, two memory meters and the budget controls. The answer to "which model should I run?" sits below the fold behind a button. The CPU row also read
AMD64 Family 25 Model 80 Stepping 0, AuthenticAMDon Windows.Change
ProcessorNameStringfrom the registry and macOS usessysctl machdep.cpu.brand_string, both falling back to the old value. Linux is unchanged.ui34toui35;docs/UI.mdand the changelog describe the new first screen.Verification
pyteston the UI, web, hardware, recommendation, starter-pack and documentation tests: 144 passed, 1 skipped (the bakeoff UI test, already marked as disabled). This includes the Playwright file with Chromium installed.AMD Ryzen 9 5900HS with Radeon Graphics.ruff check .,node --test tests/js/frontend-modules.test.mjs,git diff --check.Not verified: the macOS CPU lookup on a real Mac (mocked only), and the screen with Ollama running and models installed (covered only by the mocked Playwright run).