chore(skills): remove the legacy Codex home startup cleanup - #329
Open
BlackHole1 wants to merge 2 commits into
Open
chore(skills): remove the legacy Codex home startup cleanup#329BlackHole1 wants to merge 2 commits into
BlackHole1 wants to merge 2 commits into
Conversation
The TODO(codex-removal) routine was a temporary compatibility shim that deleted oo-managed skills from `~/.codex/skills` (or `$CODEX_HOME/skills`) and the canonical `<config>/skills/bundled/codex` storage after the Codex agent moved to the universal `~/.agents` location. Enough releases have shipped since then, so the startup run no longer needs to scan or touch the legacy Codex home. Drop `legacy-codex-cleanup.ts` with its tests and the call site in `run-cli.ts`. The `OO_SKILLS_SYNC_DISABLED` guard test that relied on the Codex cleanup now seeds a legacy `@alwaysmavs/gpt-image-2` skill instead, keeping coverage for the remaining guarded legacy cleanup. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe CLI startup flow no longer imports or invokes legacy Codex managed-skill cleanup. Bootstrap coverage removes the former legacy Codex-home deletion test and verifies that a universal managed skill, including its Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/application/bootstrap/run-cli.test.ts`:
- Around line 309-314: Strengthen the assertions in the --help test around
managedRegistryPath by verifying that both seeded files, SKILL.md and
.oo-metadata.json, still exist after sandbox.run; preferably capture their
initial contents and assert they remain unchanged, while retaining the existing
directory assertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dab71d00-3f51-4107-8dc5-0d9da002fed9
📒 Files selected for processing (4)
src/application/bootstrap/run-cli.test.tssrc/application/bootstrap/run-cli.tssrc/application/commands/skills/legacy-codex-cleanup.test.tssrc/application/commands/skills/legacy-codex-cleanup.ts
💤 Files with no reviewable changes (3)
- src/application/commands/skills/legacy-codex-cleanup.ts
- src/application/commands/skills/legacy-codex-cleanup.test.ts
- src/application/bootstrap/run-cli.ts
Directory existence alone would pass even if the cleanup deleted the seeded files while leaving the directory behind; assert SKILL.md and .oo-metadata.json are still present to make the guard test strict. Signed-off-by: Kevin Cui <bh@bugs.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TODO(codex-removal)routine was a temporary compatibility shim: after the Codex agent moved to the universal~/.agentsskills location, every CLI startup scanned~/.codex/skills(or$CODEX_HOME/skills) for oo-managed skills to delete and removed the orphaned canonical<config>/skills/bundled/codexstorage, so users wouldn't see duplicate skills. Enough releases have shipped since the migration that no user should still have oo-managed copies under the legacy Codex home, so the shim has served its purpose.This deletes
legacy-codex-cleanup.tswith its tests and the call site inrun-cli.ts. TheOO_SKILLS_SYNC_DISABLEDguard test inrun-cli.test.tspreviously relied on the Codex cleanup to prove that legacy cleanups stay inside the guarded block; it now seeds a legacy@alwaysmavs/gpt-image-2skill instead, keeping that coverage against the remaining guarded cleanup.