fix(playback): skip unchecked facet tracks - #63
Conversation
Test coverage assessment — PR #63Major
Minor
|
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: c304721f716a
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| frontend:view-state | 1 |
| tauri:config-ipc | 0 |
frontend:view-state (1 finding)
Major - apps/desktop/test/interactions.test.tsx:84
The new integration test does not cover the requested resolved-projection behavior for successful facet starts. Its Genre selection receives the same
browsefixture as the initial view, while the only changed response is an all-disabled Artist projection; Album and explicit visible-sort ordering are not exercised. Consequently, a regression that starts the prior projection (or ignoresdisplayedTracksordering) for Genre/Artist/Album can still pass. Return distinct enabled-track fixtures based on the selectedselfor each facet, set an explicit sort whose first enabled row differs from projection order, and assert the launched track/queue comes from each resolved fixture.
Reviewer Coverage
frontend:view-state— complete (constrained); skipped: none; constraints: Focused test command could not complete because the workspace lacks @tauri-apps/api, causing the existing gateways test import to fail before Vitest ran. Narrow frontend state and regression-test review only.tauri:config-ipc— complete (constrained); skipped: none; constraints: Narrow Tauri configuration/IPC review; assigned changes are frontend test files and the production diff changes no command, DTO, event, capability, CSP, or release configuration.unassigned—⚠️ unassigned; skipped:apps/desktop/src/App.tsx,apps/desktop/src/ui.ts,docs/architecture/library.md; changed files were not assigned to a selected reviewer
Inspected files (2)
apps/desktop/test/interactions.test.tsxapps/desktop/test/ui.test.ts
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 53s | gpt-5.6-terra | cr 0.10.298
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | frontend:view-state, tauri:config-ipc |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 1m 53s wall · 2m 13s compute |
| Cost | unavailable |
| Tokens | 423.0k in / 4.9k out |
Per-workstream usage
orchestrator-selection— gpt-5.6-terra- In: 17.3k
- Out: 239
- Cache read: 11.0k
- Cache create: unavailable
- Cost: unavailable
- Duration: 8s
frontend:view-state— gpt-5.6-terra- In: 248.9k
- Out: 3.1k
- Cache read: 196.1k
- Cache create: unavailable
- Cost: unavailable
- Duration: 1m 18s
tauri:config-ipc— gpt-5.6-terra- In: 136.9k
- Out: 1.5k
- Cache read: 96.3k
- Cache create: unavailable
- Cost: unavailable
- Duration: 39s
orchestrator-rollup— gpt-5.6-terra- In: 19.9k
- Out: 85
- Cache read: 17.2k
- Cache create: unavailable
- Cost: unavailable
- Duration: 5s
| }) | ||
|
|
||
| describe('mounted native interaction boundaries', () => { | ||
| it('starts a facet with its first enabled visible track', async () => { |
There was a problem hiding this comment.
The new integration test does not cover the requested resolved-projection behavior for successful facet starts. Its Genre selection receives the same browse fixture as the initial view, while the only changed response is an all-disabled Artist projection; Album and explicit visible-sort ordering are not exercised. Consequently, a regression that starts the prior projection (or ignores displayedTracks ordering) for Genre/Artist/Album can still pass. Return distinct enabled-track fixtures based on the selected sel for each facet, set an explicit sort whose first enabled row differs from projection order, and assert the launched track/queue comes from each resolved fixture.
Reply inline to this comment.
There was a problem hiding this comment.
The three columns invoke the same facet-agnostic callback with no per-facet branch. Exact projection invalidation is already covered by the pending-navigation regression, and the queue filter preserves displayed order. The mounted Genre/Artist checks plus the planned native three-column pass cover the changed behavior without duplicating fixtures.
|
These are low-value, please approve the PR |
|
Manual validation on macOS release bundle c304721: with Man! I Feel Like A Woman! unchecked, double-clicking Genre Country, Artist Shania Twain, and Album Come On Over each started the first enabled track, I’m Holdin’ On To Love. The initially reported failure was also reproduced on the pre-fix codex/60-daily-spotify-sync build. CI’s frontend failure is the existing Tauri permission-list baseline fixed on PR #61; both Windows failures are the unrelated concurrent persistence test hitting Access is denied. macOS, Ubuntu, Rust, and title checks pass. |
1 participant
Summary
Tests
cd apps/desktop && npm run test(94 passed)cd apps/desktop && npm run lintcd apps/desktop && npm run buildnode scripts/check-docs.mjsgit diff --check