Repository navigation
fix(display): render text-only dataset samples - #1765
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text-only datasets are supported by
CustomTextMCQDataset, but their inherited display method and the dataset browser renderer assume every row contains an image or image_path. Both raise KeyError for an ordinary text-only sample. Treat such samples as having no images so their index, question, choices, and answer can render.Validation: exact shipping local TSV producer and display consumers reproduce two failures on the base. Five focused regressions/controls pass after the fix, including actual Pillow base64/image-file rendering and real IPython image display; seven existing image/GPT-budget neighbors also pass (12 total). All nine pinned pre-commit hooks pass on materialized source/metadata. The test harness executes exact original definitions to avoid unrelated optional model imports and the browser script's module-level API translator. No Gradio GUI, model/provider, GPU benchmark, accuracy, or hosted CI result claimed.