Repository navigation
fix(scan): resolve workflows through readable plugin paths - #1592
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b12bbf9633
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mldangelo-oai
changed the title
mldangelo-oai
changed the title
|
@codex review |
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-cutting changes to sandboxed workflow loading, Deep worker inheritance, and archive concurrency warrant final human review.
0 open findings
What changed in this PR
Updates scan orchestration so workflows load from readable plugin paths while cached credential-home skills remain disabled.
Changes:
- Reworks scan and Deep worker skill-path configuration and prompt guidance.
- Preserves MCP startup dependencies and worker settings across profiles and resumes.
- Serializes archive registration checks to avoid rename/recreation races.
| File | Description |
|---|---|
sdk/typescript/src/scan-skill-paths.ts |
Builds isolated native skill selections. |
sdk/typescript/src/api.ts |
Integrates readable workflows and worker settings. |
sdk/typescript/scripts/check-package.mjs |
Allows the new packaged helper. |
sdk/typescript/tests-ts/scan-skill-paths.test.ts |
Tests skill selection and isolation. |
sdk/typescript/tests-ts/scan-mcp-startup.test.ts |
Tests MCP startup ordering. |
sdk/typescript/tests-ts/api.test.ts |
Tests scan and Deep worker integration. |
sdk/typescript/tests-ts/api-preflight-config.test.ts |
Tests skill-setting projection. |
plugins/codex-security/mcp-app/src/deep-scan/executor.ts |
Forwards skill settings and readable paths. |
plugins/codex-security/mcp-app/tests/test_deep_scan_executor.ts |
Tests worker inheritance and resumes. |
plugins/codex-security/scripts/workbench_db.py |
Defers archive validation until writer admission. |
plugins/codex-security/tests/test_workbench_archive.py |
Covers concurrent archive registration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…/codex/adopt-pr-1592 # Conflicts: # sdk/typescript/scripts/check-package.mjs
mldangelo-oai
changed the title
zcrab-oai
left a comment
zcrab-oai
left a comment
There was a problem hiding this comment.
Reviewed ad1488c115fb in two source-review passes, including relevant callers and contracts.
Approved. No new actionable findings in the reviewed scope.
Validation: CI-helper TypeScript compilation and plugin bundling passed locally; native binaries came from CI with matching compiled source inputs. Focused SDK tests passed: scan-skill-paths.test.ts, scan-mcp-startup.test.ts. The full cross-platform suite was not run locally; Windows execution remains unverified here.
Summary
Load the selected scan workflow from an existing readable plugin copy without losing other configured plugins or skills.
Changes
Testing
Both recorded full SDK orders passed with 4,798 tests passed and 68 skipped. Focused path/runtime tests, worker launch tests, archive regressions, portable checks, builds, types, and formatting passed.
Risk and rollout
No public command or configuration changes, and credential-home denials remain intact. The selected scan workflow loads from the existing readable plugin copy; other plugins and skill selections remain available. The newer policy-onboarding changes from main are preserved. This change is independent of the separate cost and progress fixes.
Public disclosure review