Repository navigation
feat: import GitHub code scanning and GHSA advisories to Cloud - #1632
mldangelo-oai wants to merge 57 commits into
Conversation
…ing-pr-1441-refresh
…/codex/remaining-pr-1441-refresh
…/codex/remaining-pr-1441-refresh
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the actual diff against #1441 at 9351529f6dfa9e61ae86fcbe8d678d041e2e3932 in three independent passes, including the advisory mapping, pagination, publication tests, and public API documentation. Explicit advisory selection, repository/source identity, dismissal state, failed-page handling, and original evidence preservation are consistent across the SDK and CLI.
No additional blocking findings in this diff. This depends on #1441, whose outstanding concurrent-publication finding remains relevant before the stack is merged. Static review only; no live GitHub/Cloud calls, build, or integration suite run.
alandelong-oai
left a comment
There was a problem hiding this comment.
Correction to the condition in my approval: I have withdrawn the identical-concurrent-publication finding on #1441 and approved that parent PR. My approval of this diff at 9351529f6dfa9e61ae86fcbe8d678d041e2e3932 no longer carries that condition. This remains a static review; no live integration tests run.
a6b8a8c to
5a4e664
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59949f66e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const fixedVersion = | ||
| text(vulnerability?.["first_patched_version"]) ?? | ||
| text(vulnerability?.["patched_versions"]); |
There was a problem hiding this comment.
Read the nested global patched-version identifier
For advisories returned by GitHub's global advisory endpoint, first_patched_version is an object such as { "identifier": "1.2.3" }, not a string. Passing that object to text() always returns null, so every global advisory silently publishes an empty fixed_versions array even when GitHub supplies a patch, undermining the promised preservation of patched versions. Read first_patched_version.identifier and update the synthetic fixture to use the real API shape.
AGENTS.md reference: sdk/typescript/AGENTS.md:L35-L38
Useful? React with 👍 / 👎.
Summary
Stacked on #1441. Bring saved GitHub code-scanning alerts and separately selected GHSA advisories into the existing Cloud finding-import workflow. The SDK now exposes the same preview and explicit publication boundary as the CLI.
Changes
import github OWNER/REPOcompatible and map its selected-ref evidence forpublish findings FILE --provider github.import github-advisories OWNER/REPO, defaulting to published repository advisories. Explicit GHSA IDs support repository or global advisory lookup; global lookup never enumerates the database.Testing
Validation at
b4574941, integrated with the updated #1441 parent:12345and1907551529): each had 5,156 passes, 75 skips, and the same one pre-existing installed-hook test failure reproduced on unchanged main. The suites are not fully green locally; security-installed hooks remained enabled.Risk and rollout
Requires the corresponding Cloud contract support for GitHub, advisory evidence, and unknown imported severity before use. Existing Wiz evidence serialization and retry compatibility are preserved. This adds read-only GitHub retrieval and explicit Cloud publication; it does not write back to GitHub or start an assessment.
This follow-on targets the Wiz publisher branch and depends on #1441 landing first.
Public disclosure review