Repository navigation
feat: import Semgrep SAST findings to Cloud - #1690
Draft
mldangelo-oai wants to merge 13 commits into
Draft
mldangelo-oai wants to merge 13 commits into
mldangelo-oai wants to merge 13 commits into
Conversation
# Conflicts: # sdk/typescript/src/external-findings-publish.ts
# Conflicts: # sdk/typescript/src/external-findings-publish.ts # sdk/typescript/tests-ts/external-findings-publish.test.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--provider semgrepfor Semgrep Code JSON and SARIF, including native Semgrep PRO output. Users can preview selected SAST findings, confirm publication, and repeat imports through the existing publisher. Stacked on #1689.Behavior
Uses native fingerprints when available and a deterministic rule/path/range identity for Community Edition findings. Native SARIF
%SRCROOT%paths preserve literal percent characters; direct URI paths are decoded once. Equivalent JSON and SARIF locations share their fallback identity. Moving a Community Edition finding changes that identity. Unresolved artifact indexes and custom bases remain unmapped; fingerprinted findings retain their evidence, while CE findings without a usable identity are excluded.Requires
--source-repository-urlto identify the source and match the selected Cloud repository. GitHub and Enterprise matching preserves scheme and explicit-port distinctions. Saved requests continue to use the immutable repository identity during retries.Retains selected original evidence, locations, snippets, ignored state, and source severity. Rejects incomplete scans, ambiguous duplicate identities, and unsupported products. Imported claims remain unassessed. Scan-wide path inventories and timing data are excluded from individual evidence.
Validation
Hosted CI must qualify this updated head. Live Semgrep tenant testing remains pending; this qualification uses public fixtures. Semgrep JSON/SARIF documentation.
Compatibility
Cloud must support the
semgrepprovider before publication is available. This change does not enable rollout gates, start scans, or fetch report URLs.Public disclosure review