Repository navigation
fix(telemetry): preserve controls and share request attribution - #1691
Open
mldangelo-oai wants to merge 1 commit into
Open
mldangelo-oai wants to merge 1 commit into
mldangelo-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Request attribution was duplicated or lost across helper processes, and usage could look complete when worker measurements were missing. Share request context across the existing request paths and preserve accurate usage completeness through retries.
Changes
Testing
12345and4027216356: each reported 4,918 passed, 65 skipped, and 11 authentication failures. All 11 reproduce on the base commit and are caused by an existing Git marker around the temporary checkout. The entire 128-test authentication file passes from a clean Git working directory in both orders.Risk and rollout
No new CLI flags, Action inputs, telemetry collectors, or export destinations. The Action retains
analytics.enabled=false; request attribution remains separate from native analytics and explicitly configured OTel exporters. Provider tags describe wrapper configuration; native managed-provider overrides can select a different backend. Attribution does not establish OpenAI-side reporting for other providers.Migration 50 adds a local worker-thread registry, backfills known associations, and retains them until the scan is deleted.
Public disclosure review