Skip to content

fix(plugin): separate diff revisions from paths in scan inputs - #1694

Open
WenJing95 wants to merge 1 commit into
openai:mainfrom
WenJing95:fix/rank-input-revision-separator
Open

WenJing95 wants to merge 1 commit into
openai:mainfrom
WenJing95:fix/rank-input-revision-separator

Conversation

@WenJing95

Copy link
Copy Markdown
Contributor

Summary

run_git_changed_paths runs git diff --raw without --, so Git also tries the revision args as paths. A local patch scan with --base release fails if there's also a release/ directory, and on Windows a <sha>..<sha> range fails with "Filename too long" in deep repo paths.

Changes

Added -- after the revision args, like workbench_target.py does. Added a test with a base branch named the same as a directory.

Testing

Tests pass.

Risk and rollout

Callers only pass revisions and --cached, so the selected changes stay the same.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant