Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_git_changed_pathsrunsgit diff --rawwithout--, so Git also tries the revision args as paths. A local patch scan with--base releasefails if there's also arelease/directory, and on Windows a<sha>..<sha>range fails with "Filename too long" in deep repo paths.Changes
Added
--after the revision args, likeworkbench_target.pydoes. Added a test with a base branch named the same as a directory.Testing
Tests pass.
Risk and rollout
Callers only pass revisions and
--cached, so the selected changes stay the same.Public disclosure review