Repository navigation
Add prompt-handler execution to codex-hooks - #26267
Closed
abhinav-oai wants to merge 1 commit into
Closed
abhinav-oai wants to merge 1 commit into
abhinav-oai wants to merge 1 commit into
Conversation
This was referenced Jun 3, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d729770058
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
abhinav-oai
force-pushed
the
abhinav/prompt-hooks-runtime
branch
from
June 4, 2026 00:30
d729770 to
d546866
Compare
abhinav-oai
changed the title
eternal-openai
approved these changes
Jun 11, 2026
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
abhinav-oai
force-pushed
the
abhinav/prompt-hooks-runtime
branch
from
July 10, 2026 03:25
d546866 to
ced3120
Compare
Contributor
Author
|
Moved to the internal stack: https://github.com/openai/codex-internal/pull/1384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR teaches
codex-hookshow to execute a prompt handler once a caller supplies a model runner.The hooks crate owns rendering the hook input, enforcing its size and timeout bounds, interpreting the model's
{ ok, reason }response, and mapping that response onto each hook event's existing behavior.This PR does not enable prompt hooks from configuration. Prompt handlers continue to be skipped during discovery, and Core does not provide a model runner yet. The next PR adds those pieces.
Changes
{ ok, reason }response.Stack