Repository navigation
[plugins] Route preview traffic to plugin service - #28582
Open
stevenlee-oai wants to merge 10 commits into
Open
stevenlee-oai wants to merge 10 commits into
stevenlee-oai wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d529861b60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
stevenlee-oai
marked this pull request as draft
June 16, 2026 20:36
stevenlee-oai
added a commit
that referenced
this pull request
Jun 16, 2026
stevenlee-oai
marked this pull request as ready for review
June 16, 2026 20:59
stevenlee-oai
added a commit
that referenced
this pull request
Jun 16, 2026
stevenlee-oai
added a commit
that referenced
this pull request
Jun 23, 2026
stevenlee-oai
added a commit
that referenced
this pull request
Jun 23, 2026
stevenlee-oai
force-pushed
the
dev/stevenlee/plugin-service-preview-routing
branch
from
June 23, 2026 00:37
274451f to
ef1ea9f
Compare
stevenlee-oai
force-pushed
the
dev/stevenlee/plugin-service-preview-routing
branch
from
June 23, 2026 07:11
ef1ea9f to
b8e6d66
Compare
stevenlee-oai
force-pushed
the
dev/stevenlee/plugin-service-preview-routing
branch
from
June 23, 2026 07:29
b8e6d66 to
39df203
Compare
…service-preview-routing
…service-preview-routing # Conflicts: # codex-rs/app-server/src/request_processors/plugins.rs # codex-rs/core-plugins/src/remote.rs
…service-preview-routing # Conflicts: # codex-rs/app-server/src/request_processors/plugins.rs # codex-rs/codex-mcp/src/codex_apps.rs # codex-rs/codex-mcp/src/connection_manager_tests.rs # codex-rs/codex-mcp/src/mcp/mod.rs # codex-rs/core/src/connectors.rs # codex-rs/core/src/mcp_tool_call_tests.rs # codex-rs/core/src/session/mcp.rs # codex-rs/core/src/session/session.rs
…service-preview-routing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex Thread 019ed1ea-8c0a-7862-9895-17b77fa68352
Summary
features.plugin_service_previewfeature through Codex's normal config path; Codex Apps supplies the employee-only Statsig result as the final root CLI override-c features.plugin_service_preview=true|falsein openai/openai#1038607oai-chat-plugin-service-preview=trueonly to authenticated remote-plugin, connector-directory, legacy Apps MCP, and/ps/mcpplugin-service requestsCodex does not determine employee identity. The cookie is public, untrusted routing metadata—not an authorization boundary—and existing authentication and downstream authorization remain unchanged. Cloudflare/the plugin-service gateway must independently require internal traffic before honoring it.
Validation
cargo check -p codex-features -p codex-chatgpt -p codex-mcp -p codex-core-plugins -p codex-core -p codex-app-serverjust test -p codex-features -p codex-utils-plugins -p codex-chatgpt -p codex-mcp -p codex-core-plugins(392 passed)just test -p codex-core plugin_service_preview_cli_override_reaches_plugin_service_consumersjust write-config-schemajust argument-comment-lintjust fixfor affected Rust crates (only the pre-existingRawPluginManifestHookslarge-enum warning remains)just bazel-lock-updatejust bazel-lock-checkjust fmt