Skip to content

[plugins] Route preview traffic to plugin service - #28582

Open
stevenlee-oai wants to merge 10 commits into
mainfrom
dev/stevenlee/plugin-service-preview-routing
Open

stevenlee-oai wants to merge 10 commits into
mainfrom
dev/stevenlee/plugin-service-preview-routing

Conversation

@stevenlee-oai

@stevenlee-oai stevenlee-oai commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Codex Thread 019ed1ea-8c0a-7862-9895-17b77fa68352

Summary

  • add the default-off features.plugin_service_preview feature through Codex's normal config path; Codex Apps supplies the employee-only Statsig result as the final root CLI override -c features.plugin_service_preview=true|false in openai/openai#1038607
  • add oai-chat-plugin-service-preview=true only to authenticated remote-plugin, connector-directory, legacy Apps MCP, and /ps/mcp plugin-service requests
  • strip caller-provided preview cookies when the feature is disabled, replace them when enabled, preserve unrelated and Cloudflare cookies, and keep arbitrary MCP servers and signed third-party uploads unchanged
  • separate preview and non-preview connector, remote-plugin, and Apps-tool caches so a config transition cannot reuse results from the other route

Codex does not determine employee identity. The cookie is public, untrusted routing metadata—not an authorization boundary—and existing authentication and downstream authorization remain unchanged. Cloudflare/the plugin-service gateway must independently require internal traffic before honoring it.

Validation

  • cargo check -p codex-features -p codex-chatgpt -p codex-mcp -p codex-core-plugins -p codex-core -p codex-app-server
  • just test -p codex-features -p codex-utils-plugins -p codex-chatgpt -p codex-mcp -p codex-core-plugins (392 passed)
  • just test -p codex-core plugin_service_preview_cli_override_reaches_plugin_service_consumers
  • just write-config-schema
  • just argument-comment-lint
  • scoped just fix for affected Rust crates (only the pre-existing RawPluginManifestHooks large-enum warning remains)
  • just bazel-lock-update
  • just bazel-lock-check
  • just fmt

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d529861b60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/remote.rs
Comment thread codex-rs/codex-mcp/src/mcp/mod.rs Outdated
@stevenlee-oai
stevenlee-oai marked this pull request as draft June 16, 2026 20:36
@stevenlee-oai
stevenlee-oai marked this pull request as ready for review June 16, 2026 20:59
@stevenlee-oai
stevenlee-oai requested a review from a team as a code owner June 16, 2026 20:59
@stevenlee-oai
stevenlee-oai force-pushed the dev/stevenlee/plugin-service-preview-routing branch from 274451f to ef1ea9f Compare June 23, 2026 00:37
@stevenlee-oai
stevenlee-oai force-pushed the dev/stevenlee/plugin-service-preview-routing branch from ef1ea9f to b8e6d66 Compare June 23, 2026 07:11
@stevenlee-oai
stevenlee-oai force-pushed the dev/stevenlee/plugin-service-preview-routing branch from b8e6d66 to 39df203 Compare June 23, 2026 07:29
…service-preview-routing

# Conflicts:
#	codex-rs/app-server/src/request_processors/plugins.rs
#	codex-rs/core-plugins/src/remote.rs
…service-preview-routing

# Conflicts:
#	codex-rs/app-server/src/request_processors/plugins.rs
#	codex-rs/codex-mcp/src/codex_apps.rs
#	codex-rs/codex-mcp/src/connection_manager_tests.rs
#	codex-rs/codex-mcp/src/mcp/mod.rs
#	codex-rs/core/src/connectors.rs
#	codex-rs/core/src/mcp_tool_call_tests.rs
#	codex-rs/core/src/session/mcp.rs
#	codex-rs/core/src/session/session.rs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant