Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions codex-rs/app-server/src/request_processors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,8 @@ use codex_protocol::protocol::SessionConfiguredEvent;
use codex_protocol::protocol::SessionMetaLine;
use codex_protocol::protocol::TurnEnvironmentSelection;
use codex_protocol::protocol::TurnEnvironmentSelections;
use codex_protocol::protocol::USER_MESSAGE_BEGIN;
use codex_protocol::protocol::W3cTraceContext;
use codex_protocol::protocol::strip_user_message_prefix;
use codex_protocol::user_input::MAX_USER_INPUT_TEXT_CHARS;
use codex_protocol::user_input::UserInput as CoreInputItem;
use codex_rmcp_client::perform_oauth_login_return_url_with_http_client;
Expand Down Expand Up @@ -625,10 +625,10 @@ pub(crate) use self::thread_summary::summary_to_thread;
pub(crate) use self::thread_summary::thread_settings_from_config_snapshot;
pub(crate) use self::thread_summary::thread_settings_from_core_snapshot;

pub(crate) fn build_api_turns_from_rollout_items(items: &[RolloutItem]) -> Vec<Turn> {
pub(crate) fn build_legacy_api_turns_from_rollout_items(items: &[RolloutItem]) -> Vec<Turn> {
let mut builder = ThreadHistoryBuilder::new();
for item in items {
if is_persisted_rollout_item(item) {
if is_persisted_rollout_item(item, codex_protocol::protocol::ThreadHistoryMode::Legacy) {
Comment thread
owenlin0 marked this conversation as resolved.
builder.handle_rollout_item(item);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ impl ExternalAgentSessionImporter {
memory_mode,
},
};
rollout_items.retain(is_persisted_rollout_item);
rollout_items.retain(|item| is_persisted_rollout_item(item, ThreadHistoryMode::Legacy));
let title = title
.as_deref()
.and_then(codex_core::util::normalize_thread_name);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ pub(crate) fn populate_thread_turns_from_history(
items: &[RolloutItem],
active_turn: Option<&Turn>,
) {
let mut turns = build_api_turns_from_rollout_items(items);
let mut turns = build_legacy_api_turns_from_rollout_items(items);
if let Some(active_turn) = active_turn {
merge_turn_history_with_active_turn(&mut turns, active_turn.clone());
}
Expand Down
11 changes: 4 additions & 7 deletions codex-rs/app-server/src/request_processors/thread_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2339,7 +2339,7 @@ impl ThreadRequestProcessor {
let (mut thread, history) =
thread_from_stored_thread(stored_thread, fallback_provider, &self.config.cwd);
if include_turns && let Some(history) = history {
thread.turns = build_api_turns_from_rollout_items(&history.items);
thread.turns = build_legacy_api_turns_from_rollout_items(&history.items);
}
Ok(Some(thread))
}
Expand Down Expand Up @@ -2408,7 +2408,7 @@ impl ThreadRequestProcessor {
.load_history(/*include_archived*/ true)
.await
.map_err(|err| thread_read_history_load_error(thread_id, err))?;
thread.turns = build_api_turns_from_rollout_items(&history.items);
thread.turns = build_legacy_api_turns_from_rollout_items(&history.items);
}

Ok(())
Expand Down Expand Up @@ -4107,7 +4107,7 @@ fn reconstruct_thread_turns_for_turns_list(
|| active_turn
.as_ref()
.is_some_and(|turn| matches!(turn.status, TurnStatus::InProgress));
let mut turns = build_api_turns_from_rollout_items(items);
let mut turns = build_legacy_api_turns_from_rollout_items(items);
normalize_thread_turns_status(&mut turns, loaded_status, has_live_in_progress_turn);
if let Some(active_turn) = active_turn {
merge_turn_history_with_active_turn(&mut turns, active_turn);
Expand Down Expand Up @@ -4480,10 +4480,7 @@ fn preview_from_rollout_items(items: &[RolloutItem]) -> String {
},
_ => None,
})
.map(|preview| match preview.find(USER_MESSAGE_BEGIN) {
Some(idx) => preview[idx + USER_MESSAGE_BEGIN.len()..].trim().to_string(),
None => preview,
})
.map(|preview| strip_user_message_prefix(preview.as_str()).to_string())
.unwrap_or_default()
}

Expand Down
5 changes: 1 addition & 4 deletions codex-rs/app-server/src/request_processors/thread_summary.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,7 @@ fn extract_conversation_summary(
_ => None,
})?;

let preview = match preview.find(USER_MESSAGE_BEGIN) {
Some(idx) => preview[idx + USER_MESSAGE_BEGIN.len()..].trim(),
None => preview.as_str(),
};
let preview = strip_user_message_prefix(preview.as_str());

let timestamp = if session_meta.timestamp.is_empty() {
None
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use super::*;

use anyhow::Result;
use codex_protocol::protocol::USER_MESSAGE_BEGIN;
use pretty_assertions::assert_eq;
use serde_json::json;
use std::path::PathBuf;
Expand Down
8 changes: 4 additions & 4 deletions codex-rs/core/src/session/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1376,7 +1376,7 @@ impl Session {
}
InitialHistory::Forked(mut rollout_items) => {
let turn_context = self.new_default_turn().await;
if turn_context.config.features.enabled(Feature::ItemIds) {
if turn_context.item_ids_enabled() {
for rollout_item in &mut rollout_items {
if let RolloutItem::ResponseItem(response_item) = rollout_item {
Self::assign_missing_response_item_id(response_item);
Expand Down Expand Up @@ -1959,7 +1959,7 @@ impl Session {
}

async fn send_event_raw_with_persistence(&self, event: Event, persist: bool) {
// Persist the event into rollout storage (the store filters as needed).
// Persist the event into rollout storage; the store applies its persistence policy.
if persist {
let rollout_items = vec![RolloutItem::EventMsg(event.msg.clone())];
self.persist_rollout_items(&rollout_items).await;
Expand Down Expand Up @@ -2773,7 +2773,7 @@ impl Session {
for item in items.to_mut() {
item.set_turn_id_if_missing(&turn_context.sub_id);
}
if turn_context.config.features.enabled(Feature::ItemIds) {
if turn_context.item_ids_enabled() {
Self::assign_missing_response_item_ids(items)
} else {
items
Expand Down Expand Up @@ -3032,7 +3032,7 @@ impl Session {
world_state_baseline: Option<Arc<WorldState>>,
compacted_item: CompactedItem,
) {
let items = if turn_context.config.features.enabled(Feature::ItemIds) {
let items = if turn_context.item_ids_enabled() {
Self::assign_missing_response_item_ids(Cow::Owned(items)).into_owned()
} else {
items
Expand Down
1 change: 1 addition & 0 deletions codex-rs/core/src/session/review.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ pub(super) async fn spawn_review_thread(
reasoning_effort,
reasoning_summary,
session_source,
history_mode: parent_turn_context.history_mode,
parent_thread_id: parent_turn_context.parent_thread_id,
originator: parent_turn_context.originator.clone(),
environments: parent_turn_context.environments.clone(),
Expand Down
13 changes: 11 additions & 2 deletions codex-rs/core/src/session/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,12 @@ impl Session {
},
},
};
LiveThread::resume(Arc::clone(&thread_store), params).await?
LiveThread::resume(
Arc::clone(&thread_store),
session_configuration.history_mode,
params,
)
.await?
}
};
Ok(Some(live_thread))
Expand Down Expand Up @@ -1110,7 +1115,11 @@ impl Session {
config.features.enabled(Feature::EnableRequestCompression),
config.features.enabled(Feature::RuntimeMetrics),
Self::build_model_client_beta_features_header(config.as_ref()),
/*item_ids_enabled*/ config.features.enabled(Feature::ItemIds),
/*item_ids_enabled*/ config.features.enabled(Feature::ItemIds)
|| matches!(
session_configuration.history_mode,
ThreadHistoryMode::Paginated
),
/*concurrent_reasoning_summaries_enabled*/ config
.features
.enabled(Feature::ConcurrentReasoningSummaries),
Expand Down
19 changes: 19 additions & 0 deletions codex-rs/core/src/session/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ use codex_protocol::permissions::FileSystemSandboxPolicy;
use codex_protocol::permissions::FileSystemSpecialPath;
use codex_protocol::protocol::NonSteerableTurnKind;
use codex_protocol::protocol::SandboxPolicy;
use codex_protocol::protocol::ThreadHistoryMode;
use codex_protocol::protocol::TurnEnvironmentSelections;
use codex_protocol::request_permissions::PermissionGrantScope;
use codex_protocol::request_permissions::RequestPermissionProfile;
Expand Down Expand Up @@ -257,6 +258,24 @@ fn assign_missing_response_item_ids_assigns_additional_tools_ids() {
assert!(items[0].id().is_some_and(|id| id.starts_with("at_")));
}

#[tokio::test]
async fn paginated_turn_context_assigns_missing_response_item_ids_without_feature() {
let (session, mut turn_context) = make_session_and_context().await;
turn_context.history_mode = ThreadHistoryMode::Paginated;
let response_item = user_message("hello");

let items = session.prepare_conversation_items_for_history(
&turn_context,
std::slice::from_ref(&response_item),
);

assert!(
items[0]
.id()
.is_some_and(|item_id| item_id.starts_with("msg_"))
);
}

fn assistant_message(text: &str) -> ResponseItem {
ResponseItem::Message {
id: None,
Expand Down
25 changes: 23 additions & 2 deletions codex-rs/core/src/session/turn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1916,6 +1916,21 @@ async fn drain_in_flight(
Ok(())
}

fn assign_missing_streamed_response_item_id(
item: &mut ResponseItem,
active_item: Option<&TurnItem>,
) {
if item.id().is_some() {
return;
}

let active_item_id = active_item
.map(TurnItem::id)
.filter(|item_id| !item_id.is_empty());
item.set_id(active_item_id);
Session::assign_missing_response_item_id(item);
}

#[allow(clippy::too_many_arguments)]
#[instrument(level = "trace",
skip_all,
Expand Down Expand Up @@ -2030,7 +2045,10 @@ async fn try_run_sampling_request(

match event {
ResponseEvent::Created => {}
ResponseEvent::OutputItemDone(item) => {
ResponseEvent::OutputItemDone(mut item) => {
if turn_context.item_ids_enabled() {
assign_missing_streamed_response_item_id(&mut item, active_item.as_ref());
}
if let Some((_, mut consumer)) = active_tool_argument_diff_consumer.take()
&& let Ok(Some(event)) = consumer.finish()
{
Expand Down Expand Up @@ -2124,7 +2142,10 @@ async fn try_run_sampling_request(
});
}
}
ResponseEvent::OutputItemAdded(item) => {
ResponseEvent::OutputItemAdded(mut item) => {
if turn_context.item_ids_enabled() {
assign_missing_streamed_response_item_id(&mut item, /*active_item*/ None);
}
if let ResponseItem::CustomToolCall {
call_id,
name,
Expand Down
9 changes: 9 additions & 0 deletions codex-rs/core/src/session/turn_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use codex_protocol::ThreadId;
use codex_protocol::models::AdditionalPermissionProfile;
use codex_protocol::openai_models::ModelInfo;
use codex_protocol::protocol::MultiAgentVersion;
use codex_protocol::protocol::ThreadHistoryMode;
use codex_protocol::protocol::TurnEnvironmentSelection;
use codex_sandboxing::compatibility_sandbox_policy_for_permission_profile;
use codex_sandboxing::policy_transforms::effective_file_system_sandbox_policy;
Expand Down Expand Up @@ -111,6 +112,7 @@ pub struct TurnContext {
pub(crate) reasoning_effort: Option<ReasoningEffortConfig>,
pub(crate) reasoning_summary: ReasoningSummaryConfig,
pub(crate) session_source: SessionSource,
pub(crate) history_mode: ThreadHistoryMode,
pub(crate) parent_thread_id: Option<ThreadId>,
pub(crate) originator: String,
pub(crate) environments: TurnEnvironmentSnapshot,
Expand Down Expand Up @@ -149,6 +151,11 @@ enum TurnMultiAgentRuntime {
}

impl TurnContext {
pub(crate) fn item_ids_enabled(&self) -> bool {
self.config.features.enabled(Feature::ItemIds)
|| matches!(self.history_mode, ThreadHistoryMode::Paginated)
}

pub(crate) fn permission_profile(&self) -> PermissionProfile {
self.permission_profile.clone()
}
Expand Down Expand Up @@ -262,6 +269,7 @@ impl TurnContext {
reasoning_effort,
reasoning_summary: self.reasoning_summary,
session_source: self.session_source.clone(),
history_mode: self.history_mode,
parent_thread_id: self.parent_thread_id,
originator: self.originator.clone(),
environments: self.environments.clone(),
Expand Down Expand Up @@ -541,6 +549,7 @@ impl Session {
reasoning_effort,
reasoning_summary,
session_source,
history_mode: session_configuration.history_mode,
parent_thread_id: session_configuration.parent_thread_id,
originator: session_configuration.originator.clone(),
environments,
Expand Down
70 changes: 70 additions & 0 deletions codex-rs/core/tests/suite/items.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,76 @@ async fn reasoning_item_is_emitted() -> anyhow::Result<()> {
Ok(())
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn missing_streamed_reasoning_id_is_reused_for_completion() -> anyhow::Result<()> {
skip_if_no_network!(Ok(()));

let server = start_mock_server().await;
let TestCodex { codex, .. } = test_codex()
.with_config(|config| {
let _ = config.features.enable(Feature::ItemIds);
})
.build_with_auto_env(&server)
.await?;

let mut reasoning_added = ev_reasoning_item_added("unused", &[]);
reasoning_added["item"]
.as_object_mut()
.expect("reasoning item")
.remove("id");
let mut reasoning_done = ev_reasoning_item("unused", &["Consider inputs"], &[]);
reasoning_done["item"]
.as_object_mut()
.expect("reasoning item")
.remove("id");
let response_mock = mount_sse_once(
&server,
sse(vec![
ev_response_created("resp-1"),
reasoning_added,
reasoning_done,
ev_completed("resp-1"),
]),
)
.await;

codex
.submit(Op::UserInput {
items: vec![UserInput::Text {
text: "explain your reasoning".into(),
text_elements: Vec::new(),
}],
final_output_json_schema: None,
responsesapi_client_metadata: None,
additional_context: Default::default(),
thread_settings: Default::default(),
})
.await?;

let started_id = wait_for_event_match(&codex, |ev| match ev {
EventMsg::ItemStarted(ItemStartedEvent {
item: TurnItem::Reasoning(item),
..
}) => Some(item.id.clone()),
_ => None,
})
.await;
let completed_id = wait_for_event_match(&codex, |ev| match ev {
EventMsg::ItemCompleted(ItemCompletedEvent {
item: TurnItem::Reasoning(item),
..
}) => Some(item.id.clone()),
_ => None,
})
.await;

assert!(started_id.starts_with("rs_"));
assert_eq!(started_id, completed_id);
response_mock.single_request();

Ok(())
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn web_search_item_is_emitted() -> anyhow::Result<()> {
skip_if_no_network!(Ok(()));
Expand Down
10 changes: 7 additions & 3 deletions codex-rs/protocol/src/legacy_events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,22 @@ impl ContextCompactionItem {
}

impl UserMessageItem {
pub fn as_legacy_event(&self) -> EventMsg {
pub fn as_legacy_user_message_event(&self) -> UserMessageEvent {
// Legacy user-message events flatten only text inputs into `message` and
// rebase text element ranges onto that concatenated text.
EventMsg::UserMessage(UserMessageEvent {
UserMessageEvent {
client_id: self.client_id.clone(),
message: self.message(),
images: Some(self.image_urls()),
image_details: self.image_details(),
local_images: self.local_image_paths(),
local_image_details: self.local_image_details(),
text_elements: self.text_elements(),
})
}
}

pub fn as_legacy_event(&self) -> EventMsg {
EventMsg::UserMessage(self.as_legacy_user_message_event())
}
}

Expand Down
Loading
Loading