Skip to content

fix(api)!: include retained messages in compaction output types - #3068

Merged
jbeckwith-oai merged 1 commit into
nextfrom
castiron/promotions/pr-402
Oct 28, 2026
Merged

fix(api)!: include retained messages in compaction output types#3068
jbeckwith-oai merged 1 commit into
nextfrom
castiron/promotions/pr-402

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Compaction output types include retained input messages as well as output items.

Changes

  • Use ResponseItem for compaction output; update explicitly typed output collections and item visitors.

@jbeckwith-oai
fix(api)!: include retained messages in compaction output types
2224f96 
Castiron-Internal-PR: openai/openai-node-internal#402
Castiron-Source-SHA: a8acc0fe2e66838f262d6e909a2fcbfa78b899ce
Castiron-Public-Base-SHA: 5f23520
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 28, 2026 03:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T04:01:20.746332Z 2224f96 PR opened
🔒 Security Review ✅ Completed 2026-10-28T04:01:33.100582Z 2224f96 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

markstuart-oai
markstuart-oai approved these changes Oct 28, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 28 changed paths at 2224f96951d6fe058d46e07255d64b03b89e045a. GA and beta compaction output now use the broader response-item unions, consistent with the transformed schema and retained input messages. The migration guide explains the next-major type change and the remaining request-input constraints. The new public-entrypoint fixture covers retained roles, compaction records and repeated compaction without changing request serialization.

The 19 retired reporting files match the inventory removals, and the ownership/security guidance matches the resulting tree. No actionable findings after source review and an independent pass.

Verified hosted lint, Linux/Windows builds, ecosystem checks, CodeQL and Node 22/24/26 tests passed. This was a source-only review; no local candidate tests, builds or generation ran.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 28, 2026
Merged via the queue into next with commit 85f1870 Oct 28, 2026
31 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-402 branch October 28, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes
@dpiet-oai dpiet-oai dpiet-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbeckwith-oai @markstuart-oai @dpiet-oai