Skip to content

feat(api): add compaction trigger IDs - #4122

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-296
Oct 20, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-296

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Adds optional IDs to stable and beta compaction trigger items.

Changes

  • Accept omitted, null, or string compaction trigger IDs while retaining existing construction APIs.

Castiron-Internal-PR: openai/openai-python-internal#296
Castiron-Source-SHA: 94e0389fc7204f5b49931b03f74d420a26152c08
Castiron-Public-Base-SHA: 8968560
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 20, 2026 04:05
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 20, 2026 04:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T04:07:56.953955Z 5676c39 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-20T04:09:06.225378Z 5676c39 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 8968560fb926240aea5fed8ee24e189eade57118.

Trusted main policy: 8968560fb926240aea5fed8ee24e189eade57118.

✅ No new custom-code files detected.

39 mixed files remain; 0 existing customizations changed.

Compared 8968560fb926 → 5676c39dfd1d. Generated baselines verified.

39 existing customizations unchanged
  • api.md
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/realtime/translations/translations.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/decision_input_image_param.py
  • src/openai/types/decision_input_text_param.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py
  • src/openai/types/webhooks/live_call_incoming_webhook_event.py
  • src/openai/types/webhooks/unwrap_webhook_event.py
  • tests/api_resources/test_videos.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39367784162 --repo openai/openai-python \
  --name castiron-custom-code-39367784162-1 --dir /tmp/castiron-custom-code-39367784162-1
git apply --stat /tmp/castiron-custom-code-39367784162-1/custom-code.patch
cat /tmp/castiron-custom-code-39367784162-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 8968560fb926240aea5fed8ee24e189eade57118 5676c39dfd1df08af51afdd4083454a1f0694c06
python3 scripts/castiron/custom_code_report.py report \
  --base 8968560fb926240aea5fed8ee24e189eade57118 \
  --head 5676c39dfd1df08af51afdd4083454a1f0694c06 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-5676c39dfd1d
cat /tmp/castiron-custom-code-5676c39dfd1d/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 7.164s for Python SDK PR #4122.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 160ms
tests/chat-completions-create.test.ts ✅ Passed 168ms
tests/chat-completions-stream.test.ts ✅ Passed 129ms
tests/files-content-binary.test.ts ✅ Passed 141ms
tests/files-create-multipart.test.ts ✅ Passed 195ms
tests/files-list-pagination.test.ts ✅ Passed 170ms
tests/initialize-config.test.ts ✅ Passed 145ms
tests/instance-isolation.test.ts ✅ Passed 144ms
tests/models-list.test.ts ✅ Passed 177ms
tests/responses-background-lifecycle.test.ts ✅ Passed 137ms
tests/responses-body-method-errors.test.ts ✅ Passed 218ms
tests/responses-cancel-timeout.test.ts ✅ Passed 202ms
tests/responses-cancel.test.ts ✅ Passed 144ms
tests/responses-compact-retries.test.ts ✅ Passed 217ms
tests/responses-compact.test.ts ✅ Passed 155ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 301ms
tests/responses-create-advanced.test.ts ✅ Passed 165ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.126s
tests/responses-create-errors.test.ts ✅ Passed 173ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 130ms
tests/responses-create-retries.test.ts ✅ Passed 178ms
tests/responses-create-stream-failures.test.ts ✅ Passed 91ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 211ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.555s
tests/responses-create-stream.test.ts ✅ Passed 106ms
tests/responses-create-terminal-states.test.ts ✅ Passed 165ms
tests/responses-create-timeout.test.ts ✅ Passed 213ms
tests/responses-create.test.ts ✅ Passed 198ms
tests/responses-delete.test.ts ✅ Passed 179ms
tests/responses-input-items-errors.test.ts ✅ Passed 273ms
tests/responses-input-items-list.test.ts ✅ Passed 221ms
tests/responses-input-items-options.test.ts ✅ Passed 235ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 215ms
tests/responses-input-tokens-count.test.ts ✅ Passed 171ms
tests/responses-malformed-inputs.test.ts ✅ Passed 783ms
tests/responses-not-found-errors.test.ts ✅ Passed 192ms
tests/responses-parse.test.ts ✅ Passed 176ms
tests/responses-retrieve-retries.test.ts ✅ Passed 311ms
tests/responses-retrieve.test.ts ✅ Passed 138ms
tests/responses-stored-method-errors.test.ts ✅ Passed 337ms
tests/retry-behavior.test.ts ✅ Passed 3.153s
tests/sdk-error-shape.test.ts ✅ Passed 226ms

View OkTest run #39367748149

SDK merge (287f116b8a7d) · head (5676c39dfd1d) · base (8968560fb926) · OkTest (5d04a66b7423)

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 0e5794d Oct 20, 2026
33 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-296 branch October 20, 2026 04:40
@openai-sdks openai-sdks Bot mentioned this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants