Repository navigation
chore(api): clarify project API key update requirements - #4131
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-python-internal#301 Castiron-Source-SHA: a3a9cc2797d2e163a6c4efd4ccdc1db6e1a9116d Castiron-Public-Base-SHA: b1a1a10
jbeckwith-oai
marked this pull request as ready for review
October 20, 2026 20:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Contributor
Castiron custom codeEvaluated main: Trusted main policy: Mixed files: 39 → 40 1 newly customized · 0 customizations removed · 0 existing customizations changed · 1 generated baselines changed Compared
39 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39493879742 --repo openai/openai-python \
--name castiron-custom-code-39493879742-1 --dir /tmp/castiron-custom-code-39493879742-1
git apply --stat /tmp/castiron-custom-code-39493879742-1/custom-code.patch
cat /tmp/castiron-custom-code-39493879742-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin b1a1a100d38d84dd556319e207880d85d23559cd 48183ed870079ae42c5552a46e20ab23da29a351
python3 scripts/castiron/custom_code_report.py report \
--base b1a1a100d38d84dd556319e207880d85d23559cd \
--head 48183ed870079ae42c5552a46e20ab23da29a351 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-48183ed87007
cat /tmp/castiron-custom-code-48183ed87007/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
dpiet-oai
approved these changes
Oct 20, 2026
marcuswood-oai
approved these changes
Oct 20, 2026
marcuswood-oai
left a comment
marcuswood-oai
left a comment
Contributor
There was a problem hiding this comment.
No blocking findings. Reviewed the API-key update schema and fixtures, confirmed runtime source and WebSocket docs/tests are unchanged, and reviewed the reporting/workflow changes. The reporting-helper suite passed (99 tests run, one optional test skipped), and current-head CI is green.
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
Automated Release PR --- ## [3.36.0](v3.35.1...v3.36.0) (2026-10-21) ### Features * add Vertex AI support for the Responses API ([#4139](#4139)) ([3e63d33](3e63d33)) * **api:** add 30-minute cache-write usage counts ([#4111](#4111)) ([5589146](5589146)) * **api:** add compaction trigger IDs ([#4122](#4122)) ([0e5794d](0e5794d)) * **api:** add custom voice consent management ([#4135](#4135)) ([de6d70d](de6d70d)) * **types:** prepare native synchronous WebSocket option type ([#4118](#4118)) ([90c0bac](90c0bac)) ### Bug Fixes * **api:** accept canonical batch responses in strict mode ([#4106](#4106)) ([6eaa90e](6eaa90e)) * clean up failed WebSocket setup and honor native options ([#4121](#4121)) ([b1a1a10](b1a1a10)) * end sync WebSocket recovery when an attempt is interrupted ([#4129](#4129)) ([337769b](337769b)) * honor timed Translation receives during terminal cleanup ([#4132](#4132)) ([ca54146](ca54146)) * preserve client headers in legacy Beta Realtime connections ([#4130](#4130)) ([8a2a2e0](8a2a2e0)) * preserve declared aliases during Pydantic v1 validation ([#4119](#4119)) ([8b1cac9](8b1cac9)) * preserve Vertex API root for response lifecycle ([#4140](#4140)) ([c2b14f5](c2b14f5)) * preserve WebSocket close across recovery and cancellation ([#4117](#4117)) ([4590ff1](4590ff1)) * **realtime:** honor native options for legacy beta sockets ([#4120](#4120)) ([8968560](8968560)) ### Chores * **api:** clarify cache-write token totals ([#4136](#4136)) ([55b8b8a](55b8b8a)) * **api:** clarify project API key update requirements ([#4131](#4131)) ([0e6be9f](0e6be9f)) * **api:** maintain voice consent compatibility ([#4137](#4137)) ([07abe06](07abe06)) * **api:** use neutral moderation examples ([#4104](#4104)) ([553703e](553703e)) * restore generated Castiron reporting scripts ([#4113](#4113)) ([9d12b56](9d12b56)) * support next checkpoints in the trusted reporter ([#4128](#4128)) ([ae2a6c2](ae2a6c2)) ### Documentation * plan the Python generated-code transition ([#4114](#4114)) ([6a52987](6a52987)) * record Python transition progress and batch follow-up work ([#4116](#4116)) ([46e3680](46e3680)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project API-key updates require scopes, an expiration, or both. Record this existing rule with required-only
anyOf, and supply valid scopes bodies in synchronous and asynchronous update tests.Runtime source, WebSocket documentation, and published WebSocket tests are unchanged from the public baseline, including the defaults introduced in #4121.
Validation: 340 published WebSocket tests passed; the reporting-helper suite passed (99 tests, one skipped); scoped lint and formatting passed. The trusted public-main custom-code budget is 7,352 / 10,000. Two fresh independent adversarial review rounds were clean. Current hosted validation is tracked on this PR.