Skip to content

ci: qualify next analysis checks for merge groups - #4150

Merged
jbeckwith-oai merged 1 commit into
nextfrom
codex/next-queue-analysis
Oct 22, 2026
Merged

jbeckwith-oai merged 1 commit into
nextfrom
codex/next-queue-analysis

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Next pull requests and merge groups need CodeQL and breaking-change checks that cannot be satisfied by a main-target run sharing the same head. Run CodeQL for next PRs and merge groups, and run both existing breaking-change detectors against the merge group's exact base SHA with full history. Reject missing or unrelated baselines before dependency bootstrap.

Next PR/group runs publish Analyze Python (next) and detect-breaking-changes (next). Existing main check names remain; PR retargeting retriggers evaluation. Checkout credentials are not persisted. This changes check producers only; branch protection and merge-queue activation remain separate.

Validation: actionlint passes both workflows. Focused tests cover seven event/target combinations using the actual expressions, release dispatch and edited triggers, real Git base validation, and the unchanged shell detector restoring base tests while retaining candidate SDK code. Actual hosted CodeQL and next merge-group qualification remain required before these contexts become required checks.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 22, 2026 01:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T01:57:23.064800Z 8c525da PR opened
🔒 Security Review ✅ Completed 2026-10-22T01:58:22.651726Z 8c525da PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated next: b3eca25737d570ee277f77dcb6f10691f8656ef6.

Trusted main policy: 7cd702895379656bee62047ff64813ff616aeef7.

✅ No new custom-code files detected.

48 mixed files remain; 0 existing customizations changed.

Compared b3eca25737d5 → 8c525da8b7c4. Generated baselines verified.

48 existing customizations unchanged
  • api.md
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/messages.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/fine_tuning/jobs/checkpoints.py
  • src/openai/resources/fine_tuning/jobs/jobs.py
  • src/openai/resources/models.py
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/init.py
  • src/openai/types/beta/threads/message_content.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py
  • tests/api_resources/audio/test_speech.py
  • tests/api_resources/chat/test_completions.py
  • tests/api_resources/fine_tuning/jobs/test_checkpoints.py

8 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39708538574 --repo openai/openai-python \
  --name castiron-custom-code-39708538574-1 --dir /tmp/castiron-custom-code-39708538574-1
git apply --stat /tmp/castiron-custom-code-39708538574-1/custom-code.patch
cat /tmp/castiron-custom-code-39708538574-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin b3eca25737d570ee277f77dcb6f10691f8656ef6 8c525da8b7c4dd7f31d75f63972d731e536464fb
python3 scripts/castiron/custom_code_report.py report \
  --base b3eca25737d570ee277f77dcb6f10691f8656ef6 \
  --head 8c525da8b7c4dd7f31d75f63972d731e536464fb --target-branch next --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-8c525da8b7c4
cat /tmp/castiron-custom-code-8c525da8b7c4/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai merged commit b421d9e into next Oct 22, 2026
27 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/next-queue-analysis branch October 22, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants