Repository navigation
chore(api): preserve file and video polling helpers - #4155
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-python-internal#326 Castiron-Source-SHA: 7ebb4b06ada7147f66a7e980e807b7a06b7a457b Castiron-Public-Base-SHA: a29dc39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 27 mixed files remain; 0 existing customizations changed; 5 customizations removed; 5 generated baselines changed. Compared
27 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39729743233 --repo openai/openai-python \
--name castiron-custom-code-39729743233-1 --dir /tmp/castiron-custom-code-39729743233-1
git apply --stat /tmp/castiron-custom-code-39729743233-1/custom-code.patch
cat /tmp/castiron-custom-code-39729743233-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin a29dc3947aeccecc2e85d8fbad4d7c03b8af13e9 1872a423844e331f681a5460ba07e1578f461cb2
python3 scripts/castiron/custom_code_report.py report \
--base a29dc3947aeccecc2e85d8fbad4d7c03b8af13e9 \
--head 1872a423844e331f681a5460ba07e1578f461cb2 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-1872a423844e
cat /tmp/castiron-custom-code-1872a423844e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
dpiet-oai
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves existing file, vector store, and video polling behavior.
Changes
Transition audit
Five polling files now match the generated checkpoint exactly, reducing mixed files from 32 to 27 and custom patch lines from 6,845 to 6,186. The repository plan records the completed predecessor #4152 and keeps this candidate's measurements separate from delivered results.
The API specification, public signatures/defaults/decorators, dependencies, handwritten runtimes, generation ownership and budget are unchanged. The configuration adds only seven existing polling-helper declarations while retaining all earlier settings.
Validation
Current hosted checks and SDK CODEOWNER review are required.