Repository navigation
build(deps): refresh SQLite runtime and Go lint tooling - #264
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 29, 2026, 10:09 PM ET / September 30, 2026, 02:09 UTC. ClawSweeper reviewWhat this changesUpdates Discrawl’s SQLite driver, paired libc and date-format dependency, aligns local and CI lint versions, and records the versions in release documentation. Merge readiness✅ Ready for maintainer review Keep open: current main still has the older versions, so this maintenance PR remains useful. The inspected patch has no definite correctness or security defect. Priority: P3 Review scores
Verification
How this fits togetherDiscrawl stores Discord history in a local SQLite archive that its search and diagnostic commands read. Go dependency pins affect that archive and its repair helper; the Makefile and CI workflow check the resulting source. flowchart LR
A[Discord archive inputs] --> B[Go storage layer]
B --> C[SQLite driver and libc]
C --> D[Local SQLite archive]
D --> E[Search and diagnostics]
F[Go dependency pins] --> C
F --> G[Local and CI lint checks]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Maintain a reproducible dependency set that continues to open existing archives across supported platforms without changing the stored schema or Go minimum. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a version refresh, not a reported failure; current main’s older pins are directly visible in source. Is this the best way to solve the issue? Yes: the driver and libc versions match upstream’s module requirement, and local and CI lint pins follow the repository’s existing pattern. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning high; reviewed against d481b3b56e51. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Refresh the database runtime to modernc SQLite v1.60.1 with its upstream-required libc v1.77.1, update go-strftime to v1.1.0, and align local/CI golangci-lint at v2.14.0. The Go 1.27.0 minimum, preferred Go 1.27.1 toolchain, and Crawlkit version stay unchanged. Release documentation records the new SQLite/libc pairing; Unreleased records the maintenance change.
Validation:
make checkpassed on a clean Linux amd64 AWS Crabbox with Go 1.27.1: module verification/tidiness, formatting, lint/vet/staticcheck/gosec/deadcode, govulncheck, full race tests with 86.0% coverage, CLI smoke, and all six snapshot platform builds. Cloud publisher/docs tests (15 tests), docs generation, and the source-reconciliation tests also passed.Codex autoreview completed at P0–P2 with no accepted actionable finding. Its sole finding claimed go-strftime v1.1.0 was unpublished, based on a cached tag page; the live GitHub tag, Go proxy metadata, checksum database, and clean download all independently confirm the published version.