Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
Two interface snippets omit deprecated compatibility fields retained by the linked upstream change.
2 open findings
What changed in this PR
Documents the new design-system Icon type across web apps and extensions.
Changes:
- Adds guidance for named and image icons.
- Updates extension interfaces and examples to use
Icon. - Notes deprecated sibling icon properties.
| File | Description |
|---|---|
viewer-editor-apps/鈥媔ndex.md |
Updates file-extension icons. |
extensions/鈥媔ndex.md |
Adds shared icon documentation. |
right-sidebar-panel-extensions.md |
Updates sidebar panel icons. |
resource-indicator-extensions.md |
Updates indicator icons and example. |
left-sidebar-menu-item-extensions.md |
Links to icon guidance. |
folder-view-extensions.md |
Links to icon guidance. |
floating-action-button-extensions.md |
Updates button icon type. |
app-menu-item-extensions.md |
Updates menu-item icon type. |
action-extensions.md |
Documents dynamic Icon values. |
account-extensions.md |
Updates account extension icons. |
馃 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| category: 'system' | 'sharing' | 'space' | ||
| icon: string | ||
| fillType: IconFillType | ||
| icon: Icon |
| name: string | ||
| icon: string | ||
| iconFillType?: IconFillType | ||
| icon: Icon |
Contributor
Author
|
Talked to @JammingBen: we both disagree with CoPilot here. We find it's confusing to have that in the docs. |
dschmidt
marked this pull request as draft
October 8, 2026 10:00
JammingBen
approved these changes
Oct 8, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
LGTM 馃憤 Marked as draft until after the upcoming rolling release has been released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Documents the
Icontype introduced in opencloud-eu/web#3580: an icon name, a named icon withfillTypeandcolor, or an image icon withsrcandsrcDark.icon: Iconand link to that section.iconFillType,iconColorandfillTypeare described as deprecated.Should only be merged after the web PR (is released?)