Repository navigation
feat(authguest): added redeem endpoint for auth-guest service - #76
Merged
Merged
Conversation
maki5
requested review from
butonic,
dragotin,
fschade,
kulmann,
micbar and
rhafer
as code owners
September 29, 2026 15:38
rhafer
requested changes
Sep 30, 2026
| message: | ||
| type: string | ||
| description: Human-readable error message. | ||
| share_id: |
Member
There was a problem hiding this comment.
I think we'd better name this permissionId. As this is how shares are represented in the GraphAPI.
| Host-only, HttpOnly and Secure guest session cookie (default name | ||
| `__Host-oc_guest_session`). | ||
| schema: | ||
| type: string |
Member
There was a problem hiding this comment.
As just discussed with @kulmann this endpoint should also return a response body including the shareId/permissionId.
aduffeck
reviewed
Oct 1, 2026
| name: "secret stuff" | ||
| default: | ||
| $ref: '#/components/responses/error' | ||
| '/v1beta1/extensions/org.libregraph/guestInvitations/redeem': |
Member
There was a problem hiding this comment.
After another discussion with @rhafer we thought it might be better to name this /v1beta1/extensions/org.libregraph/guestLinks instead.
rhafer
requested changes
Oct 1, 2026
rhafer
left a comment
rhafer
left a comment
Member
There was a problem hiding this comment.
For consistency we should also rename all the occurrences of guestInvitaion(s) with guestLink(s). E.g. guestInvitationRedeemResponse -> guestLinkRedeemResponse
Other than that I think this looks good.
aduffeck
approved these changes
Oct 1, 2026
rhafer
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for: opencloud-eu/opencloud#3609