Repository navigation
fix: keep the file list up to date after uploads - #3587
Merged
Merged
Conversation
JammingBen
requested changes
Oct 8, 2026
Comment on lines
+84
to
+86
| const existingEtags = new Map(resourcesStore.resources.map((r) => [r.id, r.etag])) | ||
| const changedResources = children.filter((child) => existingEtags.get(child.id) !== child.etag) | ||
| resourcesStore.upsertResources(changedResources) |
Member
There was a problem hiding this comment.
upsertResources doesn't merge but overwrites resources, leading to thumbnail and remoteItemId getting lost. You can see this in a share space, where replacing a resource now resets the preview image to the default one (because SSE isn't there to cover for it).
Member
Author
There was a problem hiding this comment.
Good catch, this turned out to be a general problem: a changed row is never re-rendered, so its preview isn't loaded again. Rows and tiles are now keyed by etag (fixes it for SSE, uploads and other updates), and the upload sets the share id like the folder loader does.
This also fixes:
- Replaced files without SSE: on
mainthe list didn't update replaced files at all, the old preview, size and etag stayed. - Previews in the tiles view after SSE updates: the SSE handler loads thumbnail-sized previews, the re-rendered tile now loads one in tile size.
- Saving in apps:
AppWrappersets the new etag after saving, so the list now shows the updated preview instead of the old one.
JammingBen
approved these changes
Oct 9, 2026
AlexAndBear
force-pushed
the
fix/file-list-after-uploads
branch
from
October 9, 2026 12:38
dace666 to
c90a6db
Compare
openclouders
pushed a commit
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes